'Re: Review Request: Add a GUI to configure window's title bar blend'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Add a GUI to configure window's title bar blend
From:       "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date:       2011-03-08 17:23:57
Message-ID: 20110308172357.22760.21883 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100821/
-----------------------------------------------------------

(Updated March 8, 2011, 5:23 p.m.)

Review request for KDE Base Apps and kwin.

Changes
-------

Use "Secondary" instead of "Blend" as suggested.

Also reorder the items so that the 3 "Active" settings come
together, followed by the 3 "Inactive" settings.

kwin group added to reviewers.

Summary
-------

Some of the still available window decorations (KDE2, Keramik, Modern System, Quartz,
Redmond) use two colours for the title bar, either as a blend or for different
parts of the bar.  This patch extends the GUI in System Settings to allow the
blend colour to be configured.

This addresses bug 225837.
    http://bugs.kde.org/show_bug.cgi?id=225837

Diffs (updated)
-----

  kcontrol/colors/colorscm.h 7627db8 
  kcontrol/colors/colorscm.cpp 571ed86 
  kcontrol/colors/colorsettings.ui efd618b 

Diff: http://git.reviewboard.kde.org/r/100821/diff

Testing
-------

Built kde-workspace with these changes, verified operation of systemsettings and KDE2 window decoration.

Screenshots
-----------

kcontrol screenshot
  http://git.reviewboard.kde.org/r/100821/s/93/

Thanks,

Jonathan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100821/">http://git.reviewboard.kde.org/r/100821/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Base Apps and kwin.</div>
<div>By Jonathan Marten.</div>

<p style="color: grey;"><i>Updated March 8, 2011, 5:23 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use &quot;Secondary&quot; instead of &quot;Blend&quot; as suggested.

Also reorder the items so that the 3 &quot;Active&quot; settings come
together, followed by the 3 &quot;Inactive&quot; settings.

kwin group added to reviewers.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Some of the still available window decorations (KDE2, Keramik, Modern \
System, Quartz, Redmond) use two colours for the title bar, either as a blend or for \
different parts of the bar.  This patch extends the GUI in System Settings to allow \
the blend colour to be configured.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built kde-workspace with these changes, verified operation of \
systemsettings and KDE2 window decoration. </pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=225837">225837</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kcontrol/colors/colorscm.h <span style="color: grey">(7627db8)</span></li>

 <li>kcontrol/colors/colorscm.cpp <span style="color: grey">(571ed86)</span></li>

 <li>kcontrol/colors/colorsettings.ui <span style="color: grey">(efd618b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100821/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/100821/s/93/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/03/08/225837a_400x100.png" \
style="border: 1px black solid;" alt="kcontrol screenshot" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 