From kwin Tue Mar 08 17:23:57 2011 From: "Jonathan Marten" Date: Tue, 08 Mar 2011 17:23:57 +0000 To: kwin Subject: Re: Review Request: Add a GUI to configure window's title bar blend Message-Id: <20110308172357.22760.21883 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=129960516706560 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0772099856==" --===============0772099856== Content-Type: multipart/alternative; boundary="===============0630532799600867285==" --===============0630532799600867285== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100821/ ----------------------------------------------------------- (Updated March 8, 2011, 5:23 p.m.) Review request for KDE Base Apps and kwin. Changes ------- Use "Secondary" instead of "Blend" as suggested. Also reorder the items so that the 3 "Active" settings come together, followed by the 3 "Inactive" settings. kwin group added to reviewers. Summary ------- Some of the still available window decorations (KDE2, Keramik, Modern Syste= m, Quartz, Redmond) use two colours for the title bar, either as a blend or for differ= ent parts of the bar. This patch extends the GUI in System Settings to allow t= he blend colour to be configured. This addresses bug 225837. http://bugs.kde.org/show_bug.cgi?id=3D225837 Diffs (updated) ----- kcontrol/colors/colorscm.h 7627db8 = kcontrol/colors/colorscm.cpp 571ed86 = kcontrol/colors/colorsettings.ui efd618b = Diff: http://git.reviewboard.kde.org/r/100821/diff Testing ------- Built kde-workspace with these changes, verified operation of systemsetting= s and KDE2 window decoration. Screenshots ----------- kcontrol screenshot http://git.reviewboard.kde.org/r/100821/s/93/ Thanks, Jonathan --===============0630532799600867285== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100821/

Review request for KDE Base Apps and kwin.
By Jonathan Marten.

Updated March 8, 2011, 5:23 p.m.

Changes 
Use "Secondary" instead of "Blend" as su=
ggested.

Also reorder the items so that the 3 "Active" settings come
together, followed by the 3 "Inactive" settings.

kwin group added to reviewers.

Descripti= on 

Some of the still available window decorations (KDE2, Kerami=
k, Modern System, Quartz,
Redmond) use two colours for the title bar, either as a blend or for differ=
ent
parts of the bar.  This patch extends the GUI in System Settings to allow t=
he
blend colour to be configured.

Testing <= /h1> 
Built kde-workspace with these changes, verified operation o=
f systemsettings and KDE2 window decoration.
Bugs: 225837

Diffs= (updated)

  • kcontrol/colors/colorscm.h (7627db8)
  • kcontrol/colors/colorscm.cpp (571ed86)
  • kcontrol/colors/colorsettings.ui (efd618b)=

View Diff

Screensho= ts

3D"kcontrol
--===============0630532799600867285==-- --===============0772099856== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============0772099856==--