[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: clean up & simplify quicktile / quick maximize
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-02-16 23:56:50
Message-ID: 20110216235650.12940.70766 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100664/
-----------------------------------------------------------
(Updated Feb. 16, 2011, 11:56 p.m.)
Review request for kwin.
Changes
-------
collect some related functions in quicktiling.cpp (maybe there should be mo=
re, maybe less, dunno), style/ws fixes, use QFlags
For the moment i kept the desktop() as
a) different virtual desktop can have different struts (there's no hard lin=
k between sticky and docktype and with plasma + activities i think this is =
actually a relevant case)
b) while we only allow quicktiling for moving windows or by shortcut on the=
active client (which has to be on currentDesktop()) we might end up allowi=
ng scripts or whatever to use this on any kind of client
If you want to rule out (b) (eg. by setting the client to currentDesktop or=
aborting against scripts) i'll remove it with the next update or push.
Please notice that further condensing starts to interfere with http://git.r=
eviewboard.kde.org/r/100606/ so i'll do a 2nd pass after that patch has bee=
n accepted or denied anyway :-)
Summary
-------
clean up & simplify quicktile / quick maximize code
in a second pass one should maybe align function names & simplify the shor=
tcut slots (using one slot reading qobject_cast<QAction*>(sender())->data()
Diffs (updated)
-----
kwin/CMakeLists.txt eecf901 =
kwin/client.h e6f2ef4 =
kwin/events.cpp 390313f =
kwin/geometry.cpp 99e190b =
kwin/lib/kwinglobals.h 8bb7565 =
kwin/placement.cpp 0f3d4d3 =
kwin/quicktiling.cpp PRE-CREATION =
kwin/workspace.cpp 922de17 =
Diff: http://git.reviewboard.kde.org/r/100664/diff
Testing
-------
yes, everything from moving windows to edges to using shortcuts
Thanks,
Thomas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100664/">http://git.reviewboard.kde.org/r/100664/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 16, 2011, 11:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">collect some related functions in quicktiling.cpp (maybe there should be \
more, maybe less, dunno), style/ws fixes, use QFlags For the moment i kept the \
desktop() as a) different virtual desktop can have different struts (there's no \
hard link between sticky and docktype and with plasma + activities i think this is \
actually a relevant case) b) while we only allow quicktiling for moving windows or by \
shortcut on the active client (which has to be on currentDesktop()) we might end up \
allowing scripts or whatever to use this on any kind of client
If you want to rule out (b) (eg. by setting the client to currentDesktop or aborting \
against scripts) i'll remove it with the next update or push. Please notice that \
further condensing starts to interfere with http://git.reviewboard.kde.org/r/100606/ \
so i'll do a 2nd pass after that patch has been accepted or denied anyway \
:-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">clean up & simplify quicktile / quick maximize code in a second pass \
one should maybe align function names & simplify the shortcut slots (using one \
slot reading qobject_cast<QAction*>(sender())->data()</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, everything from moving windows to edges to using shortcuts</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/CMakeLists.txt <span style="color: grey">(eecf901)</span></li>
<li>kwin/client.h <span style="color: grey">(e6f2ef4)</span></li>
<li>kwin/events.cpp <span style="color: grey">(390313f)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(99e190b)</span></li>
<li>kwin/lib/kwinglobals.h <span style="color: grey">(8bb7565)</span></li>
<li>kwin/placement.cpp <span style="color: grey">(0f3d4d3)</span></li>
<li>kwin/quicktiling.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(922de17)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100664/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic