[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: clean up & simplify quicktile / quick maximize
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2011-02-16 20:20:18
Message-ID: 20110216202018.5171.38473 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 16, 2011, 6:10 p.m., Martin Gräßlin wrote:
> > In general it looks nice and is a small little code cleanup :-) There are some \
> > red areas and coding style missmatches (here we have to be careful or our big \
> > rewrite wasn't worth it).
> > As you know had a look at the code: do you think it would be possible to refactor \
> > the code into an own class? I don't like that parts of it are split in different \
> > files (yes that's my own fault).
>
> Thomas Lübking wrote:
> More a namespace ("static" functions on clients and the workspace - what's mot very \
> ObjectOriented) but one would still have to call them from events.cpp, geometry.cpp \
> & placement.cpp. Also, the client will have to keep and provide access to it's \
> related state vars as pre_tiling area, electricMaximizing, electricMode, etc.
> As a "QnD" solution one could do what kwin does anyway and collect the \
> implementations in "quicktiling.cpp" - looking at tiling.cpp + tilinglayout/tile, \
> the quicktile code is, relative to it's size mostly tied to the client.
moving to quicktiling.cpp might really be a solution and I think you are right: it's \
nothing for object orientation
> On Feb. 16, 2011, 6:10 p.m., Martin Gräßlin wrote:
> > kwin/client.h, line 265
> > <http://git.reviewboard.kde.org/r/100664/diff/1/?file=9242#file9242line265>
> >
> > I don't think we need the desktop here. Looking through the patch it seems like \
> > it's only called once and desktop is only used for clientArea where desktop \
> > basically does not matter.
>
> Thomas Lübking wrote:
> as long as it's guaranteed that Workspace::currentDesktop() == Client::desktop() in \
> Workspace::showElectricBorderWindowOutline() or actually all VD share the same \
> geometry (what about 3rd party docks or "Activity Per Desktop"?)
QuickTiling can only happen for a moving window which is of course on the current \
desktop. I am not aware that it is possible to have desktops of different size. That \
doesn't sound right to me...
> On Feb. 16, 2011, 6:10 p.m., Martin Gräßlin wrote:
> > kwin/lib/kwinglobals.h, lines 82-91
> > <http://git.reviewboard.kde.org/r/100664/diff/1/?file=9245#file9245line82>
> >
> > just an idea: as it's now basically flags why not use QFlags so that we do not \
> > need to pass ints around? I would like to have it a little bit more type safe..
>
> Thomas Lübking wrote:
> I will use QFlag if you want.
> I just never use it - hey, why take a class for a POD job =)
ask the trolls :-) Personally I think it's more handy as you get compile errors in \
case of mismatch and a cleaner api (no ints). Btw you don't need to write the class - \
Q_DECLARE_FLAGS is your friend.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100664/#review1462
-----------------------------------------------------------
On Feb. 15, 2011, 11:09 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100664/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2011, 11:09 p.m.)
>
>
> Review request for kwin.
>
>
> Summary
> -------
>
> clean up & simplify quicktile / quick maximize code
> in a second pass one should maybe align function names & simplify the shortcut \
> slots (using one slot reading qobject_cast<QAction*>(sender())->data()
>
> Diffs
> -----
>
> kwin/events.cpp 390313f
> kwin/client.h e6f2ef4
> kwin/geometry.cpp 99e190b
> kwin/lib/kwinglobals.h 8bb7565
> kwin/placement.cpp 0f3d4d3
> kwin/workspace.cpp 922de17
>
> Diff: http://git.reviewboard.kde.org/r/100664/diff
>
>
> Testing
> -------
>
> yes, everything from moving windows to edges to using shortcuts
>
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100664/">http://git.reviewboard.kde.org/r/100664/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 16th, 2011, 6:10 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In general it looks nice and is a small little code cleanup :-) There \
are some red areas and coding style missmatches (here we have to be careful or our \
big rewrite wasn't worth it).
As you know had a look at the code: do you think it would be possible to refactor the \
code into an own class? I don't like that parts of it are split in different \
files (yes that's my own fault).</pre> </blockquote>
<p>On February 16th, 2011, 7:41 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">More a namespace \
("static" functions on clients and the workspace - what's mot very \
ObjectOriented) but one would still have to call them from events.cpp, geometry.cpp \
& placement.cpp. Also, the client will have to keep and provide access to \
it's related state vars as pre_tiling area, electricMaximizing, electricMode, \
etc.
As a "QnD" solution one could do what kwin does anyway and collect the \
implementations in "quicktiling.cpp" - looking at tiling.cpp + \
tilinglayout/tile, the quicktile code is, relative to it's size mostly tied to \
the client.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">moving to \
quicktiling.cpp might really be a solution and I think you are right: it's \
nothing for object orientation</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 16th, 2011, 6:10 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/100664/diff/1/?file=9242#file9242line265" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/client.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">265</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QRect</span> <span class="n">electricBorderMaximizeGeometry</span><span \
class="p">();</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">265</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QRect</span> <span \
class="n">electricBorderMaximizeGeometry</span><span class="p">(</span><span \
class="n"><span class="hl">QPoint</span></span><span class="hl"> </span><span \
class="n"><span class="hl">pos</span></span><span class="p"><span \
class="hl">,</span></span><span class="hl"> </span><span class="kt"><span \
class="hl">int</span></span><span class="hl"> </span><span class="n"><span \
class="hl">desktop</span></span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think we \
need the desktop here. Looking through the patch it seems like it's only called \
once and desktop is only used for clientArea where desktop basically does not \
matter.</pre> </blockquote>
<p>On February 16th, 2011, 6:36 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">as long as it's \
guaranteed that Workspace::currentDesktop() == Client::desktop() in \
Workspace::showElectricBorderWindowOutline() or actually all VD share the same \
geometry (what about 3rd party docks or "Activity Per Desktop"?)</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QuickTiling \
can only happen for a moving window which is of course on the current desktop. I am \
not aware that it is possible to have desktops of different size. That doesn't \
sound right to me...</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 16th, 2011, 6:10 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/100664/diff/1/?file=9245#file9245line82" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/lib/kwinglobals.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">enum QuickTileMode {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">82</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">enum</span> \
<span class="n">QuickTileMode</span> <span class="p">{</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">72</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="k">enum</span> <span class="n">QuickTileMode</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">83</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QuickTileNone</span><span class="p">,</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">73</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QuickTileNone</span><span class="hl"> </span><span class="o"><span \
class="hl">=</span></span><span class="hl"> </span><span class="mi"><span \
class="hl">0</span></span><span class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">84</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QuickTileLeft</span><span class="p">,</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">74</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QuickTileLeft</span><span class="hl"> </span><span class="o"><span \
class="hl">=</span></span><span class="hl"> </span><span class="mi"><span \
class="hl">1</span></span><span class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">85</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QuickTileRight</span><span class="p">,</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">75</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QuickTileRight</span><span class="hl"> </span><span class="o"><span \
class="hl">=</span></span><span class="hl"> </span><span class="mi"><span \
class="hl">1</span></span><span class="o"><span \
class="hl"><<</span></span><span class="mi"><span \
class="hl">1</span></span><span class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">86</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QuickTileTop<span class="hl">Left</span></span><span \
class="p">,</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">76</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QuickTileTop</span><span \
class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> \
</span><span class="mi"><span class="hl">1</span></span><span class="o"><span \
class="hl"><<</span></span><span class="mi"><span \
class="hl">2</span></span><span class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">87</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QuickTile<span class="hl">TopRight</span></span><span \
class="p">,</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">77</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QuickTile<span \
class="hl">Bottom</span></span><span class="hl"> </span><span class="o"><span \
class="hl">=</span></span><span class="hl"> </span><span class="mi"><span \
class="hl">1</span></span><span class="o"><span \
class="hl"><<</span></span><span class="mi"><span \
class="hl">3</span></span><span class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">88</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QuickTileBottomLeft</span><span class="p">,</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">78</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QuickTileHorizontal</span> <span class="o">=</span> <span \
class="n">QuickTileLeft</span><span class="o">|</span><span \
class="n">QuickTileRight</span><span class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">89</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QuickTileBottomRight</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">79</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QuickTileVertical</span> <span class="o">=</span> <span \
class="n">QuickTileTop</span><span class="o">|</span><span \
class="n">QuickTileBottom</span><span class="p">,</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">80</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QuickTileMaximize</span> <span class="o">=</span> <span \
class="n">QuickTileLeft</span><span class="o">|</span><span \
class="n">QuickTileRight</span><span class="o">|</span><span \
class="n">QuickTileTop</span><span class="o">|</span><span \
class="n">QuickTileBottom</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">90</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">};</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">81</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="p">};</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just an idea: as \
it's now basically flags why not use QFlags so that we do not need to pass ints \
around? I would like to have it a little bit more type safe..</pre> </blockquote>
<p>On February 16th, 2011, 6:44 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I will use QFlag if you \
want. I just never use it - hey, why take a class for a POD job =)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ask the \
trolls :-) Personally I think it's more handy as you get compile errors in case \
of mismatch and a cleaner api (no ints). Btw you don't need to write the class - \
Q_DECLARE_FLAGS is your friend.</pre> <br />
<p>- Martin</p>
<br />
<p>On February 15th, 2011, 11:09 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2011, 11:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">clean up & simplify quicktile / quick maximize code in a second pass \
one should maybe align function names & simplify the shortcut slots (using one \
slot reading qobject_cast<QAction*>(sender())->data()</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes, everything from moving windows to edges to using shortcuts</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/events.cpp <span style="color: grey">(390313f)</span></li>
<li>kwin/client.h <span style="color: grey">(e6f2ef4)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(99e190b)</span></li>
<li>kwin/lib/kwinglobals.h <span style="color: grey">(8bb7565)</span></li>
<li>kwin/placement.cpp <span style="color: grey">(0f3d4d3)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(922de17)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100664/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic