[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Show desktop in tabbox if there're no windows
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2010-12-22 20:22:03
Message-ID: 20101222202203.16897.76715 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-12-22 16:23:17, Martin Gräßlin wrote:
> > If we do that, we can drop all the code relating to "No Windows".
>
> Thomas Lübking wrote:
> The driving question would be "if we *want to* do that", this was rather a \
> proposal. (I hadn't seen the "*** No Windows ***" message ever before, never \
> attempted to alt+tab on an empty desktop ;-)
> -> you maintain, you choose =P
> (i'm oc. gonna remove the code bodies in case)
I only knew it was there because I saw it in the code and kept it. Thinking about it:
* it does not make sense to minimize to desktop if there is only the desktop
* it does not make sense to have the tabbox shown (effects fall back to the ***no \
windows***)
* though some feedback is required
Maybe there is a better way to give that feedback? Showing a passive notification?
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6187/#review9369
-----------------------------------------------------------
On 2010-12-22 16:17:19, Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6187/
> -----------------------------------------------------------
>
> (Updated 2010-12-22 16:17:19)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Summary
> -------
>
> Shows the desktop in the tabbox if there're no windows on this desktop and \
> regardless of the configuration Avoids "*** No Windows ***"
>
>
> This addresses bug 260938.
> https://bugs.kde.org/show_bug.cgi?id=260938
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/kwin/tabbox/clientmodel.cpp 1208403
>
> Diff: http://svn.reviewboard.kde.org/r/6187/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6187/">http://svn.reviewboard.kde.org/r/6187/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 22nd, 2010, 4:23 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If we do that, we can drop all the code relating to "No \
Windows".</pre> </blockquote>
<p>On December 22nd, 2010, 7:49 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The driving question \
would be "if we *want to* do that", this was rather a proposal. (I \
hadn't seen the "*** No Windows ***" message ever before, never \
attempted to alt+tab on an empty desktop ;-)
-> you maintain, you choose =P
(i'm oc. gonna remove the code bodies in case)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I only knew it was there \
because I saw it in the code and kept it. Thinking about it:
* it does not make sense to minimize to desktop if there is only the desktop
* it does not make sense to have the tabbox shown (effects fall back to the ***no \
windows***)
* though some feedback is required
Maybe there is a better way to give that feedback? Showing a passive \
notification?</pre> <br />
<p>- Martin</p>
<br />
<p>On December 22nd, 2010, 4:17 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated 2010-12-22 16:17:19</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Shows the desktop in the tabbox if there're no windows on this \
desktop and regardless of the configuration Avoids "*** No Windows \
***"</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=260938">260938</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kwin/tabbox/clientmodel.cpp <span style="color: \
grey">(1208403)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6187/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic