--===============0200639285== Content-Type: multipart/alternative; boundary="===============0925394389642840675==" --===============0925394389642840675== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-12-22 16:23:17, Martin Gr=C3=A4=C3=9Flin wrote: > > If we do that, we can drop all the code relating to "No Windows". > = > Thomas L=C3=BCbking wrote: > The driving question would be "if we *want to* do that", this was rat= her a proposal. > (I hadn't seen the "*** No Windows ***" message ever before, never at= tempted to alt+tab on an empty desktop ;-) > = > -> you maintain, you choose =3DP > (i'm oc. gonna remove the code bodies in case) I only knew it was there because I saw it in the code and kept it. Thinking= about it: * it does not make sense to minimize to desktop if there is only the desktop * it does not make sense to have the tabbox shown (effects fall back to the= ***no windows***) * though some feedback is required Maybe there is a better way to give that feedback? Showing a passive notifi= cation? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6187/#review9369 ----------------------------------------------------------- On 2010-12-22 16:17:19, Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6187/ > ----------------------------------------------------------- > = > (Updated 2010-12-22 16:17:19) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Summary > ------- > = > Shows the desktop in the tabbox if there're no windows on this desktop an= d regardless of the configuration > Avoids "*** No Windows ***" > = > = > This addresses bug 260938. > https://bugs.kde.org/show_bug.cgi?id=3D260938 > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/workspace/kwin/tabbox/clientmodel.cpp 1208403 = > = > Diff: http://svn.reviewboard.kde.org/r/6187/diff > = > = > Testing > ------- > = > = > Thanks, > = > Thomas > = > --===============0925394389642840675== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6187/

On December 22nd, 2010, 4:23 p.m., Martin G= r=C3=A4=C3=9Flin wrote:

If we do =
that, we can drop all the code relating to "No Windows".

On December 22nd, 2010, 7:49 p.m., Thomas L=C3=BCbking wrote:

The drivi=
ng question would be "if we *want to* do that", this was rather a=
 proposal.
(I hadn't seen the "*** No Windows ***" message ever before, =
never attempted to alt+tab on an empty desktop ;-)

-> you maintain, you choose =3DP
(i'm oc. gonna remove the code bodies in case)

I only knew=
 it was there because I saw it in the code and kept it. Thinking about it:
* it does not make sense to minimize to desktop if there is only the desktop
* it does not make sense to have the tabbox shown (effects fall back to the=
 ***no windows***)
* though some feedback is required

Maybe there is a better way to give that feedback? Showing a passive notifi=
cation?

- Martin

On December 22nd, 2010, 4:17 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

By Thomas L=C3=BCbking.

Updated 2010-12-22 16:17:19

Descripti= on

Shows the desktop in the tabbox if there're no windows o=
n this desktop and regardless of the configuration
Avoids "*** No Windows ***"

Bugs: 260938

Diffs=

/trunk/KDE/kdebase/workspace/kwin/tabbox/clientmodel.cpp (1208403)

--===============0925394389642840675==-- --===============0200639285== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============0200639285==--