[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: adjust activateNextClient() policy
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2010-12-20 18:10:51
Message-ID: 20101220181051.28506.93086 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5830/#review9344
-----------------------------------------------------------
Ship it!
Somehow I thought that one was already committed...
- Martin
On 2010-11-11 21:42:20, Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5830/
> -----------------------------------------------------------
>
> (Updated 2010-11-11 21:42:20)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Summary
> -------
>
> this commit:
> http://websvn.kde.org/trunk/KDE/kdebase/workspace/kwin/activation.cpp?r1=742984&r2=802097
> caused a change in the way kwin passes the focus on if eg. the currently \
> active window is closed and has caused some stir in a rum bottle (see bug \
> & dupes)
> Windows of the same group were preferred what could have been any other \
> dolphin window or some mail if you closed kmails main client. In addition \
> the new client wasn't raised what took it into keyboard but maybe out of \
> user focus.
> The patch adjusts this policy in that the focus is not passed to "some" \
> other window of the group but only the one the current was transient for \
> (eg. but not only modal dialogs like open/save)
> In addition the mainwindow (if picked) is raised to ensure the user "gets \
> it"
> Other restrictions like same desktop/activity or samescreen policy remain \
> untouched.
>
> This addresses bug 183911.
> https://bugs.kde.org/show_bug.cgi?id=183911
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/kwin/activation.cpp 1195645
>
> Diff: http://svn.reviewboard.kde.org/r/5830/diff
>
>
> Testing
> -------
>
> opened, closed and focussed some windows
>
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5830/">http://svn.reviewboard.kde.org/r/5830/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Somehow I thought that one was already committed...</pre> <br \
/>
<p>- Martin</p>
<br />
<p>On November 11th, 2010, 9:42 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated 2010-11-11 21:42:20</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this commit: \
http://websvn.kde.org/trunk/KDE/kdebase/workspace/kwin/activation.cpp?r1=742984&r2=802097
caused a change in the way kwin passes the focus on if eg. the currently \
active window is closed and has caused some stir in a rum bottle (see bug \
& dupes)
Windows of the same group were preferred what could have been any other \
dolphin window or some mail if you closed kmails main client. In addition \
the new client wasn't raised what took it into keyboard but maybe out \
of user focus.
The patch adjusts this policy in that the focus is not passed to \
"some" other window of the group but only the one the current was \
transient for (eg. but not only modal dialogs like open/save)
In addition the mainwindow (if picked) is raised to ensure the user \
"gets it"
Other restrictions like same desktop/activity or samescreen policy remain \
untouched.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">opened, closed and focussed some windows</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=183911">183911</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kwin/activation.cpp <span style="color: \
grey">(1195645)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5830/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic