--===============0038257933== Content-Type: multipart/alternative; boundary="===============5270336826167954847==" --===============5270336826167954847== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5830/#review9344 ----------------------------------------------------------- Ship it! Somehow I thought that one was already committed... - Martin On 2010-11-11 21:42:20, Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5830/ > ----------------------------------------------------------- > = > (Updated 2010-11-11 21:42:20) > = > = > Review request for kwin and Martin Gr=C3=A4=C3=9Flin. > = > = > Summary > ------- > = > this commit: > http://websvn.kde.org/trunk/KDE/kdebase/workspace/kwin/activation.cpp?r1= =3D742984&r2=3D802097 > caused a change in the way kwin passes the focus on if eg. the currently = active window is closed and has caused some stir in a rum bottle (see bug &= dupes) > = > Windows of the same group were preferred what could have been any other d= olphin window or some mail if you closed kmails main client. In addition th= e new client wasn't raised what took it into keyboard but maybe out of user= focus. > = > The patch adjusts this policy in that the focus is not passed to "some" o= ther window of the group but only the one the current was transient for (eg= . but not only modal dialogs like open/save) > = > In addition the mainwindow (if picked) is raised to ensure the user "gets= it" > = > Other restrictions like same desktop/activity or samescreen policy remain= untouched. > = > = > This addresses bug 183911. > https://bugs.kde.org/show_bug.cgi?id=3D183911 > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/workspace/kwin/activation.cpp 1195645 = > = > Diff: http://svn.reviewboard.kde.org/r/5830/diff > = > = > Testing > ------- > = > opened, closed and focussed some windows > = > = > Thanks, > = > Thomas > = > --===============5270336826167954847== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5830/

Ship it!

Somehow I =
thought that one was already committed...

- Martin

On November 11th, 2010, 9:42 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

By Thomas L=C3=BCbking.

Updated 2010-11-11 21:42:20

Descripti= on

this commit:
http://websvn.kde.org/trunk/KDE/kdebase/workspace/kwin/activation.cpp?r1=3D=
742984&r2=3D802097
caused a change in the way kwin passes the focus on if eg. the currently ac=
tive window is closed and has caused some stir in a rum bottle (see bug &am=
p; dupes)

Windows of the same group were preferred what could have been any other dol=
phin window or some mail if you closed kmails main client. In addition the =
new client wasn't raised what took it into keyboard but maybe out of us=
er focus.

The patch adjusts this policy in that the focus is not passed to "some=
" other window of the group but only the one the current was transient=
 for (eg. but not only modal dialogs like open/save)

In addition the mainwindow (if picked) is raised to ensure the user "g=
ets it"

Other restrictions like same desktop/activity or samescreen policy remain u=
ntouched.

Testing <= /h1>

opened, closed and focussed some windows

Bugs: 183911

Diffs=

/trunk/KDE/kdebase/workspace/kwin/activation.cpp (1195645)

--===============5270336826167954847==-- --===============0038257933== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============0038257933==--