'Re: Review Request: better activation of SessionInteract windows'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: better activation of SessionInteract windows
From:       "Chani Armitage" <chanika () gmail ! com>
Date:       2010-12-16 13:10:42
Message-ID: 20101216131042.13891.36091 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6029/
-----------------------------------------------------------

(Updated 2010-12-16 13:10:42.015323)

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

Changes
-------

this is a completely different patch :)

Summary (updated)
-------

here's a new approach: have a sessioninteract var, and when it's set, *pret=
end* to be on all activities and desktops.

it shows the "do you want to save..." window nicely. however, it doesn't sh=
ow the parent window containing the document. should it? (I think I can hac=
k that in by setting the var on the parent too)

I preserved the 'allow' behaviour here, too, since I don't quite grok it.

Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/kwin/client.h 1206051 =

  trunk/KDE/kdebase/workspace/kwin/client.cpp 1206051 =

  trunk/KDE/kdebase/workspace/kwin/manage.cpp 1206051 =

Diff: http://svn.reviewboard.kde.org/r/6029/diff

Testing
-------

Thanks,

Chani

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6029/">http://svn.reviewboard.kde.org/r/6029/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Chani Armitage.</div>

<p style="color: grey;"><i>Updated 2010-12-16 13:10:42.015323</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this is a completely different patch :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">here&#39;s a new approach: have a sessioninteract var, and when it&#39;s \
set, *pretend* to be on all activities and desktops.

it shows the &quot;do you want to save...&quot; window nicely. however, it \
doesn&#39;t show the parent window containing the document. should it? (I think I can \
hack that in by setting the var on the parent too)

I preserved the &#39;allow&#39; behaviour here, too, since I don&#39;t quite grok \
it.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdebase/workspace/kwin/client.h <span style="color: \
grey">(1206051)</span></li>

 <li>trunk/KDE/kdebase/workspace/kwin/client.cpp <span style="color: \
grey">(1206051)</span></li>

 <li>trunk/KDE/kdebase/workspace/kwin/manage.cpp <span style="color: \
grey">(1206051)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6029/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 