'Review Request: better activation of SessionInteract windows'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: better activation of SessionInteract windows
From:       "Chani Armitage" <chanika () gmail ! com>
Date:       2010-12-02 13:18:33
Message-ID: 20101202131833.3158.95377 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6029/
-----------------------------------------------------------

Review request for kwin.

Summary
-------

this turns out to be the cleanest way to get kwin to switch to the activity=
 of a window that might be blocking logout (for the moment I'm ignoring the=
 "what if it's closed" issue - that isn't kwin's problem).

however, it makes the code above it partially redundant, and I don't quite =
grok this 'allow' flag. should I perhaps merge the two code blocks, have it=
 forcibly activated on *either* allow or sessionsaving?

Diffs
-----

  trunk/KDE/kdebase/workspace/kwin/manage.cpp 1201689 =

Diff: http://svn.reviewboard.kde.org/r/6029/diff

Testing
-------

Thanks,

Chani

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6029/">http://svn.reviewboard.kde.org/r/6029/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Chani Armitage.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this turns out to be the cleanest way to get kwin to switch to the \
activity of a window that might be blocking logout (for the moment I&#39;m ignoring \
the &quot;what if it&#39;s closed&quot; issue - that isn&#39;t kwin&#39;s problem).

however, it makes the code above it partially redundant, and I don&#39;t quite grok \
this &#39;allow&#39; flag. should I perhaps merge the two code blocks, have it \
forcibly activated on *either* allow or sessionsaving?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdebase/workspace/kwin/manage.cpp <span style="color: \
grey">(1201689)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6029/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 