[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Make KWin able to kill frozen clients using
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2010-11-09 15:58:53
Message-ID: 20101109155853.2462.35134 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/4460/#review8582
-----------------------------------------------------------
Sorry, that we missed to commit this feature :-( We are already in soft-feature \
freeze and will hit hard-feature freeze later this week. So I fear we cannot add it \
to 4.6.
I will set me a reminder to go through the feature requests as soon as trunk opens up \
again. Feel free to leave a note or ping me :-)
And again sorry
- Martin
On 2010-06-26 15:05:01, Mikael Gerdin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/4460/
> -----------------------------------------------------------
>
> (Updated 2010-06-26 15:05:01)
>
>
> Review request for kwin.
>
>
> Summary
> -------
>
> Makes KWin's window killer able to kill processes running as other users.
> I just re-used the code used in krunner's (and ksysguard's) process lister
> to kill processes using elevated privileges.
>
> As it works now it only tries to use elevated privileges if kill returns EPERM.
>
>
> This addresses bug 129476.
> https://bugs.kde.org/show_bug.cgi?id=129476
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/kwin/killer/killer.cpp 1143106
>
> Diff: http://svn.reviewboard.kde.org/r/4460/diff
>
>
> Testing
> -------
>
> Manual testing by calling the helper app manually and by making a
> root-owned X window hang and click the "X" to make kwin try to kill it.
>
>
> Thanks,
>
> Mikael
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/4460/">http://svn.reviewboard.kde.org/r/4460/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, that we missed to \
commit this feature :-( We are already in soft-feature freeze and will hit \
hard-feature freeze later this week. So I fear we cannot add it to 4.6.
I will set me a reminder to go through the feature requests as soon as trunk opens up \
again. Feel free to leave a note or ping me :-)
And again sorry</pre>
<br />
<p>- Martin</p>
<br />
<p>On June 26th, 2010, 3:05 p.m., Mikael Gerdin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Mikael Gerdin.</div>
<p style="color: grey;"><i>Updated 2010-06-26 15:05:01</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Makes KWin's window killer able to kill processes running as other \
users. I just re-used the code used in krunner's (and ksysguard's) process \
lister to kill processes using elevated privileges.
As it works now it only tries to use elevated privileges if kill returns EPERM.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual testing by calling the helper app manually and by making a \
root-owned X window hang and click the "X" to make kwin try to kill \
it.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=129476">129476</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kwin/killer/killer.cpp <span style="color: \
grey">(1143106)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/4460/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic