[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Make KWin able to kill frozen clients using
From: "Mikael Gerdin" <mikael.gerdin () gmail ! com>
Date: 2010-07-06 16:29:33
Message-ID: 20100706162933.19704.21252 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-07-05 06:19:45, Martin Gräßlin wrote:
> > Nice addition and looks fine. Just out of interest one question: What happens if \
> > the KAuth action is not present? Will it be a noop or will it throw an error \
> > message_
It should do nothing. As I understand KAuth if the action does not exist it will not \
be valid and then killAsRoot will simply return and nothing will happen, it will work \
just as kwin did before.
- Mikael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4460/#review6366
-----------------------------------------------------------
On 2010-06-26 15:05:01, Mikael Gerdin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4460/
> -----------------------------------------------------------
>
> (Updated 2010-06-26 15:05:01)
>
>
> Review request for kwin.
>
>
> Summary
> -------
>
> Makes KWin's window killer able to kill processes running as other users.
> I just re-used the code used in krunner's (and ksysguard's) process lister
> to kill processes using elevated privileges.
>
> As it works now it only tries to use elevated privileges if kill returns EPERM.
>
>
> This addresses bug 129476.
> https://bugs.kde.org/show_bug.cgi?id=129476
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/kwin/killer/killer.cpp 1143106
>
> Diff: http://reviewboard.kde.org/r/4460/diff
>
>
> Testing
> -------
>
> Manual testing by calling the helper app manually and by making a
> root-owned X window hang and click the "X" to make kwin try to kill it.
>
>
> Thanks,
>
> Mikael
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4460/">http://reviewboard.kde.org/r/4460/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 5th, 2010, 6:19 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre>Nice addition and looks fine. Just out of \
interest one question: What happens if the KAuth action is not present? Will it be a \
noop or will it throw an error message_</pre> </blockquote>
</blockquote>
<pre>It should do nothing. As I understand KAuth if the action does not exist it will \
not be valid and then killAsRoot will simply return and nothing will happen, it will \
work just as kwin did before.</pre> <br />
<p>- Mikael</p>
<br />
<p>On June 26th, 2010, 3:05 p.m., Mikael Gerdin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Mikael Gerdin.</div>
<p style="color: grey;"><i>Updated 2010-06-26 15:05:01</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Makes KWin's window killer able to kill \
processes running as other users. I just re-used the code used in krunner's (and \
ksysguard's) process lister to kill processes using elevated privileges.
As it works now it only tries to use elevated privileges if kill returns EPERM.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Manual testing by calling the helper app \
manually and by making a root-owned X window hang and click the "X" to make \
kwin try to kill it.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=129476">129476</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kwin/killer/killer.cpp <span style="color: \
grey">(1143106)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4460/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic