[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: kwin wobbly windows resize patch
From:       "Lucas Murray" <lmurray () undefinedfire ! com>
Date:       2008-11-28 9:39:52
Message-ID: f09827650811280139m5b19364av6ff9841d25198071 () mail ! gmail ! com
[Download RAW message or body]

On Sun, Nov 23, 2008 at 9:03 PM, Toby Dickenson <toby@tarind.com> wrote:
> Thanks for taking the time to review this.
>
> On Saturday 22 November 2008, Cédric Borgese wrote:
>> I didn't tested it yet, but the patch looks good except line 1070, you set
>> the position of each constrained point to its original position. this has
>> at least twos effects :
>
> Those effects were intentional for fixing the vibration seen on the opposite
> corner from the dragged point. I want that point to not move at all. Attached
> is a new patch which limits these effects to that case.
>
> (This approach calms the worst of those vibrations, but the Resize operation
> is still not as fluid as Move. Pinning the opposite corner in this way is
> maybe too harsh, and the interior still vibrates rather than wobbles. I may
> yet come back with some further changes)
>
>> On Saturday 22 November 2008 15:10:46 Lucas Murray wrote:
>> > The patch is good, except if the user decides to resize a side instead
>> > of a corner.
>
> I think it still looks ok, although I agree my rationale breaks down.
>
> I tried adding logic so that it constrains the opposite _side_ if dragging a
> _side_, but it doesnt look good. It doesnt wobble enough.

What about just constraining the center of the opposite side, instead
of both the opposite corners?

>> > Do you have a Subversion account? If not resubmit the
>> > updated patch.
>
> No I dont have a svn account. Thanks for assisting with this.
>
>
> --
> Toby Dickenson
>
> _______________________________________________
> kwin mailing list
> kwin@kde.org
> https://mail.kde.org/mailman/listinfo/kwin
>
>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread]