[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: kwin wobbly windows resize patch
From:       Cédric_Borgese <cedric.borgese () gmail ! com>
Date:       2008-11-27 21:47:53
Message-ID: 200811272346.46553.cedric.borgese () gmail ! com
[Download RAW message or body]

On Sunday 23 November 2008 13:03:48 Toby Dickenson wrote:
> Thanks for taking the time to review this.
>
> On Saturday 22 November 2008, Cédric Borgese wrote:
> > I didn't tested it yet, but the patch looks good except line 1070, you
> > set the position of each constrained point to its original position. this
> > has at least twos effects :
>
> Those effects were intentional for fixing the vibration seen on the
> opposite corner from the dragged point. I want that point to not move at
> all. Attached is a new patch which limits these effects to that case.
>
> (This approach calms the worst of those vibrations, but the Resize
> operation is still not as fluid as Move. Pinning the opposite corner in
> this way is maybe too harsh, and the interior still vibrates rather than
> wobbles. I may yet come back with some further changes)
>
> > On Saturday 22 November 2008 15:10:46 Lucas Murray wrote:
> > > The patch is good, except if the user decides to resize a side instead
> > > of a corner.
>
> I think it still looks ok, although I agree my rationale breaks down.

When the window is resized by an edge, you can lock the whole opposite edge. 
this should do the trick.


>
> I tried adding logic so that it constrains the opposite _side_ if dragging
> a _side_, but it doesnt look good. It doesnt wobble enough.
>
> > > Do you have a Subversion account? If not resubmit the
> > > updated patch.
>
> No I dont have a svn account. Thanks for assisting with this.

I tested your patch and resizing is definitivly better with it :)

So I do the commit as you don't have svn account yet. Thanks.

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread]