[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: [PATCH] Menu translucency in the "Translucency" plug-in
From:       Magnus Romnes <romnes () stud ! ntnu ! no>
Date:       2008-03-12 12:08:38
Message-ID: 200803121308.38654.romnes () stud ! ntnu ! no
[Download RAW message or body]

On Wednesday, 12. March 2008 11:57:06 Lubos Lunak wrote:
> On Tuesday 11 of March 2008, romnes@stud.ntnu.no wrote:
> > Hi,
> >
> > This patch adds support for translucent menus via the "Translucency"
> > plug-in for kwmin. It partially fixes Bug #158988 and was also attached
> > in that report, but I was asked to also send it here since I am
> > applying for a SVN account -- so here it is. I will also try to take a
> > look at the rest of that bug report (rules.cpp).
>
>  Rules are a bit of copy&pasting of code, I haven't found any way how to
> make adding a new rule simpler :-/. Basically just pick one setting with
> similar semantics WRT rules, e.g. SkipTaskbar (it's a set rule, i.e. the
> user can manually tweak the setting) and just search whole of kwin/ for
> 'SkipTaskbar' and 'skiptaskbar' and add the same for translucency.

Sounds good. I'll take a look at it tonight. The idea is to make the "Active o
pacity in %" and "Inactive opacity in %" options from "Special Window Settings
" and "Special Application Settings" work as they should, right? 

> > The patch works fine for me, i was however a bit unsure what exactly
>
>  Yes, it looks ok to me.
>
> > the difference between isMenu(), isDropdownMenu() and isPopupMenu()
> > is. As a result I added a check for all three, and it seems to work
> > fine.
>
>  I've added apidocs for the is* functions - isMenu() is a torn-off menu,

Are there any examples of this sort of menu currently in KDE 4?

> isDropdownMenu() is a popup from a menubar (it opens in the downwards
> direction),  isPopupMenu() is a normal popup menu. The latter two probably
> differ only in semantics, but the first one can be seen as a quite
> different type. Also, isCombo() is a popup from a combobox, so that one
> should belong here as well.  I suggest extending the patch to have separate
> setting for each of them (and with QWhatsThis repeating what I said :) ). 

Sounds like a good idea, i'll update the patch and send a new revision.

> Note that this applies just to the configuration in the effect, not to
> rules, as rules can already specify the window type to which they apply.



_______________________________________________
Kwin mailing list
Kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]