[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: [PATCH] Menu translucency in the "Translucency" plug-in
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2008-03-12 10:57:06
Message-ID: 200803121157.06404.l.lunak () suse ! cz
[Download RAW message or body]

On Tuesday 11 of March 2008, romnes@stud.ntnu.no wrote:
> Hi,
>
> This patch adds support for translucent menus via the "Translucency"
> plug-in for kwin. It partially fixes Bug #158988 and was also attached
> in that report, but I was asked to also send it here since I am
> applying for a SVN account -- so here it is. I will also try to take a
> look at the rest of that bug report (rules.cpp).

 Rules are a bit of copy&pasting of code, I haven't found any way how to make 
adding a new rule simpler :-/. Basically just pick one setting with similar 
semantics WRT rules, e.g. SkipTaskbar (it's a set rule, i.e. the user can 
manually tweak the setting) and just search whole of kwin/ for 'SkipTaskbar' 
and 'skiptaskbar' and add the same for translucency.

> The patch works fine for me, i was however a bit unsure what exactly

 Yes, it looks ok to me.

> the difference between isMenu(), isDropdownMenu() and isPopupMenu()
> is. As a result I added a check for all three, and it seems to work
> fine.

 I've added apidocs for the is* functions - isMenu() is a torn-off menu, 
isDropdownMenu() is a popup from a menubar (it opens in the downwards 
direction), isPopupMenu() is a normal popup menu. The latter two probably 
differ only in semantics, but the first one can be seen as a quite different 
type. Also, isCombo() is a popup from a combobox, so that one should belong 
here as well. I suggest extending the patch to have separate setting for each 
of them (and with QWhatsThis repeating what I said :) ).  Note that this 
applies just to the configuration in the effect, not to rules, as rules can 
already specify the window type to which they apply.

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak@suse.cz , l.lunak@kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http://www.suse.cz
_______________________________________________
Kwin mailing list
Kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]