[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: [Kwin] KWin brekage: client_popup removal
From:       Lubos Lunak <l.lunak () suse ! cz>
Date:       2002-09-04 7:28:04
[Download RAW message or body]

On Tuesday 03 September 2002 19:16, Matthias Ettrich wrote:
> On Tuesday 03 September 2002 18:49, Lubos Lunak wrote:
> > On Tuesday 03 September 2002 18:08, Matthias Ettrich wrote:
> > > On Tuesday 03 September 2002 17:38, Matthias Ettrich wrote:
> > > [snip]
> > >
> > > > Lubos, wanna give it a try?
> > >
> > > Sorry, couldn't resist. Did it now and seems to work. Please update
> > > workspace.*
> > >
> > > Should fix most (all?) bug cases, but I haven't yet tested it
> > > thoroughly.
> >
> >  Seems to work fine, even though it looked very suspiciously :). I just
> > fixed BCI (somebody should do this for who KDE before 3.1 anyway).
>
> You meaning change the nice Client* popup_client back to
> QGuardedPtr<Client> popup_client?  Why? I did this change on purpose and it
> does not break binary compatibility.
>
> It's a private variable, both Client* and QGuardedPtr have the same size.
>
> Did you experience a BCI with it or had you just been guessing? :)

 I just saw changing the type of a data member. But it looks like it's 
reasonable to expect sizeof( QGuardedPtr< X* > ) == sizeof( X* ).

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak@suse.cz , l.lunak@kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/
_______________________________________________
Kwin mailing list
Kwin@mail.kde.org
http://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]