[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    [Kwin] [PATCH] Dock-app windows
From:       John Firebaugh <jfirebaugh () kde ! org>
Date:       2002-09-03 19:50:57
[Download RAW message or body]

As many users have reported, KDE's handling of Window Maker dock applications 
has regressed since 2.x.

http://bugs.kde.org/db/41/41828.html

Basically, dock application consists of two windows, one created in the 
WithdrawnState initially and with a window manager hint consisting of the id 
of the other window, which is to be embedded in the dock. Though the 
embedding of the icon window works correctly, there are several problems with 
the kwin/taskbar handling of the withdrawn window.

1. Withdrawn windows appear in the taskbar and tab-box list; thus they can be 
made visible by clicking the taskbar entry or Alt-Tabbing to them.
2. Withdrawn windows are shown when switching desktops.

I'm not certain of the best way to fix #1, but the following patch fixes #2.

-John
["workspace.diff" (text/x-diff)]

Index: workspace.cpp
===================================================================
RCS file: /home/kde/kdebase/kwin/workspace.cpp,v
retrieving revision 1.360
diff -u -3 -p -r1.360 workspace.cpp
--- workspace.cpp	2002/09/03 16:47:41	1.360
+++ workspace.cpp	2002/09/03 19:45:55
@@ -2274,7 +2274,7 @@ void Workspace::setCurrentDesktop( int n
         rootInfo->setCurrentDesktop( current_desktop ); // propagate befor the shows \
below  
         for ( ClientList::ConstIterator it = stacking_order.fromLast(); it != \
                stacking_order.end(); --it) {
-            if ( (*it)->isOnDesktop( new_desktop ) && !(*it)->isIconified() ) {
+            if ( (*it)->isOnDesktop( new_desktop ) && (*it)->isNormal() ) {
                 (*it)->show();
 //                mapList += (*it);
             }


_______________________________________________
Kwin mailing list
Kwin@mail.kde.org
http://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread]