[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    Re: Build is broken in 3.6.7 without CFitsio
From:       Jasem Mutlaq <mutlaqja () ikarustech ! com>
Date:       2023-12-19 5:04:39
Message-ID: CAE0bU5nDXhMW_XM26sKf8NxXcU25PtTz=RQ3QiT_vFgb-EUmaw () mail ! gmail ! com
[Download RAW message or body]

THank you for the report. cfitsio is optional, I can confirm the issue. Hy
added ImageOverlayComponent in 3.6.8 that includes fitsdata. So we either
disable this component when cfitsio is not detected, or we enable it but as
an #ifdef around line imageoverlaycomponent.cpp line 392

--
Best Regards,
Jasem Mutlaq



On Tue, Dec 19, 2023 at 12:45 AM Albert Astals Cid <aacid@kde.org> wrote:

> Please CC me I'm not on the list.
>
>
>
> You can see the log here
>
> https://buildbot.flathub.org/api/v2/logs/3498660/raw
>
> CFitsio is marked as not found
>
> -- The following OPTIONAL packages have not been found:
>
>  * CFitsio, FITS IO Library, <https://heasarc.gsfc.nasa.gov/fitsio/
> fitsio.html <https://heasarc.gsfc.nasa.gov/fitsio/fitsio.html>>
>    Support for the FITS (Flexible Image Transport System) data format in
> KStars.
>
>
> but then it's tried to be used anyway.
>
>
> /run/build/kstars/kstars/fitsviewer/fitsdata.h:33:10: fatal error:
> fitsio.h:
> No such file or directory
>    33 | #include <fitsio.h>
>
>
> What is the fix? Should CFitsio be made mandatory? Or is there a way to
> make
> it compile without it?
>
> Cheers,
>   Albert
>
> Please CC me I'm not on the list.
>
>
>
>

[Attachment #3 (text/html)]

<div dir="ltr">THank you for the report. cfitsio is optional, I can confirm  the \
issue. Hy added ImageOverlayComponent in 3.6.8 that includes fitsdata. So we either \
disable this component when cfitsio is not detected, or we enable it but as an #ifdef \
around line imageoverlaycomponent.cpp line 392<div><br clear="all"><div><div \
dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div \
dir="ltr"><div><div dir="ltr"><div>--</div><div>Best Regards,<br>Jasem \
Mutlaq<br></div><div><br></div></div></div></div></div></div><br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Dec 19, 2023 at \
12:45 AM Albert Astals Cid &lt;<a href="mailto:aacid@kde.org">aacid@kde.org</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Please CC me I&#39;m \
not on the list.<br> <br>
<br>
<br>
You can see the log here<br>
<br>
<a href="https://buildbot.flathub.org/api/v2/logs/3498660/raw" rel="noreferrer" \
target="_blank">https://buildbot.flathub.org/api/v2/logs/3498660/raw</a><br> <br>
CFitsio is marked as not found<br>
<br>
-- The following OPTIONAL packages have not been found:<br>
<br>
  * CFitsio, FITS IO Library, &lt;<a \
href="https://heasarc.gsfc.nasa.gov/fitsio/fitsio.html" rel="noreferrer" \
target="_blank">https://heasarc.gsfc.nasa.gov/fitsio/<br> fitsio.html</a>&gt;<br>
     Support for the FITS (Flexible Image Transport System) data format in <br>
KStars.<br>
<br>
<br>
but then it&#39;s tried to be used anyway.<br>
<br>
<br>
/run/build/kstars/kstars/fitsviewer/fitsdata.h:33:10: fatal error: fitsio.h: <br>
No such file or directory<br>
     33 | #include &lt;fitsio.h&gt;<br>
<br>
<br>
What is the fix? Should CFitsio be made mandatory? Or is there a way to make <br>
it compile without it?<br>
<br>
Cheers,<br>
   Albert<br>
<br>
Please CC me I&#39;m not on the list.<br>
<br>
<br>
<br>
</blockquote></div>



[prev in list] [next in list] [prev in thread] [next in thread]