From kstars-devel  Tue Dec 19 05:04:39 2023
From: Jasem Mutlaq <mutlaqja () ikarustech ! com>
Date: Tue, 19 Dec 2023 05:04:39 +0000
To: kstars-devel
Subject: Re: Build is broken in 3.6.7 without CFitsio
Message-Id: <CAE0bU5nDXhMW_XM26sKf8NxXcU25PtTz=RQ3QiT_vFgb-EUmaw () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=kstars-devel&m=170296227310675
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--000000000000620830060cd5ce7d"

--000000000000620830060cd5ce7d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

THank you for the report. cfitsio is optional, I can confirm the issue. Hy
added ImageOverlayComponent in 3.6.8 that includes fitsdata. So we either
disable this component when cfitsio is not detected, or we enable it but as
an #ifdef around line imageoverlaycomponent.cpp line 392

--
Best Regards,
Jasem Mutlaq



On Tue, Dec 19, 2023 at 12:45=E2=80=AFAM Albert Astals Cid <aacid@kde.org> =
wrote:

> Please CC me I'm not on the list.
>
>
>
> You can see the log here
>
> https://buildbot.flathub.org/api/v2/logs/3498660/raw
>
> CFitsio is marked as not found
>
> -- The following OPTIONAL packages have not been found:
>
>  * CFitsio, FITS IO Library, <https://heasarc.gsfc.nasa.gov/fitsio/
> fitsio.html <https://heasarc.gsfc.nasa.gov/fitsio/fitsio.html>>
>    Support for the FITS (Flexible Image Transport System) data format in
> KStars.
>
>
> but then it's tried to be used anyway.
>
>
> /run/build/kstars/kstars/fitsviewer/fitsdata.h:33:10: fatal error:
> fitsio.h:
> No such file or directory
>    33 | #include <fitsio.h>
>
>
> What is the fix? Should CFitsio be made mandatory? Or is there a way to
> make
> it compile without it?
>
> Cheers,
>   Albert
>
> Please CC me I'm not on the list.
>
>
>
>

--000000000000620830060cd5ce7d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">THank you for the report. cfitsio is optional, I can confi=
rm=C2=A0the issue. Hy added ImageOverlayComponent in 3.6.8 that includes fi=
tsdata. So we either disable this component when cfitsio is not detected, o=
r we enable it but as an #ifdef around line imageoverlaycomponent.cpp line =
392<div><br clear=3D"all"><div><div dir=3D"ltr" class=3D"gmail_signature" d=
ata-smartmail=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><d=
iv>--</div><div>Best Regards,<br>Jasem Mutlaq<br></div><div><br></div></div=
></div></div></div></div><br></div></div><br><div class=3D"gmail_quote"><di=
v dir=3D"ltr" class=3D"gmail_attr">On Tue, Dec 19, 2023 at 12:45=E2=80=AFAM=
 Albert Astals Cid &lt;<a href=3D"mailto:aacid@kde.org">aacid@kde.org</a>&g=
t; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0p=
x 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Please=
 CC me I&#39;m not on the list.<br>
<br>
<br>
<br>
You can see the log here<br>
<br>
<a href=3D"https://buildbot.flathub.org/api/v2/logs/3498660/raw" rel=3D"nor=
eferrer" target=3D"_blank">https://buildbot.flathub.org/api/v2/logs/3498660=
/raw</a><br>
<br>
CFitsio is marked as not found<br>
<br>
-- The following OPTIONAL packages have not been found:<br>
<br>
=C2=A0* CFitsio, FITS IO Library, &lt;<a href=3D"https://heasarc.gsfc.nasa.=
gov/fitsio/fitsio.html" rel=3D"noreferrer" target=3D"_blank">https://heasar=
c.gsfc.nasa.gov/fitsio/<br>
fitsio.html</a>&gt;<br>
=C2=A0 =C2=A0Support for the FITS (Flexible Image Transport System) data fo=
rmat in <br>
KStars.<br>
<br>
<br>
but then it&#39;s tried to be used anyway.<br>
<br>
<br>
/run/build/kstars/kstars/fitsviewer/fitsdata.h:33:10: fatal error: fitsio.h=
: <br>
No such file or directory<br>
=C2=A0 =C2=A033 | #include &lt;fitsio.h&gt;<br>
<br>
<br>
What is the fix? Should CFitsio be made mandatory? Or is there a way to mak=
e <br>
it compile without it?<br>
<br>
Cheers,<br>
=C2=A0 Albert<br>
<br>
Please CC me I&#39;m not on the list.<br>
<br>
<br>
<br>
</blockquote></div>

--000000000000620830060cd5ce7d--