[prev in list] [next in list] [prev in thread] [next in thread]
List: kstars-devel
Subject: Re: Kstars 3.6.0 MacOS find Object crash
From: Jasem Mutlaq <mutlaqja () ikarustech ! com>
Date: 2022-08-17 6:06:12
Message-ID: CAE0bU5noceQk1QtCrO7=Yarj4DVkjvdZOUomjFJKUPus72yxLw () mail ! gmail ! com
[Download RAW message or body]
I received one report for Find Dialog crash as well on Raspberry Pi, so
perhaps it's not unique to MacOS?
However, I couldn't reproduce on Raspberry PI, Widows, or any x86-64
machine.
--
Best Regards,
Jasem Mutlaq
On Wed, Aug 17, 2022 at 8:52 AM Robert Lancaster <rlancaste@gmail.com>
wrote:
> Ok I did some more testing.
>
> This commit is when the Find Dialog broke when running KStars on MacOS by
> double clicking the app:
>
>
> https://github.com/KDE/kstars/commit/5a2ba9f8e8b275f44b7593a50ca66f09cb2f985d#diff-c2a2ab763404c18a2daee3feb8b31f2ec278034e7cc720870c4e5158081e0ee9
>
> I think that is the one you were hoping was not the one. I still don't
> know why it broke it though. Every time I run it from terminal or qt
> creator there is no problem. It is just when running it by double clicking
> that is the problem.
>
> Note that I did test playing with the environment variables in qt creator
> and that seemed to have no effect. And it also didn't seem to matter
> whether kstars was packaged up or not, so it doesn't seem to be a packaging
> issue.
>
> On Aug 16, 2022, at 2:11 PM, Akarsh Simha <akarshsimha@gmail.com> wrote:
>
> If I am to blame for this, the parallelism introduced in the asynchronous
> find dialog is my suspect, rather than the comet regex (which was actually
> Hy and not me). The regex seems unlikely to cause the erratic behavior
> Robert is observing where it runs fine under a debugger.
>
> But if it works fine when running KStars from a command line, that
> probably exonerates me and Hy, and is likely an environment issue like
> Robert points out!
>
> Regards
> Akarsh
>
>
> On Tue, Aug 16, 2022 at 07:28 Robert Lancaster <rlancaste@gmail.com>
> wrote:
>
> > Hey guys,
> >
> > I just got back from my two week trip to the Southwest. Yesterday I
> > resolved the issue with building a dmg with my script, so now I can build
> > DMGs that will work with older Macs and have all the features we want in
> > the dmg.
> >
> > Next we can look into this Find Dialog bug. I did some experiments today
> > and I found that if I run kstars from the command line or in a debugger,
> > the find dialog works fine, but when running the app by double clicking it
> > crashes when you first access the find dialog. This seems to me to
> > indicate an environment issue, like maybe an issue with environment
> > variables or maybe a link to a library that isn't properly in the app. I
> > will check further.
> >
> > Thanks,
> >
> > Rob
> >
> > On Aug 13, 2022, at 6:09 AM, John Evans <john.e.evans.email@gmail.com>
> > wrote:
> >
> > I have the same problem with 3.6.0. Crashes everytime the find object
> > dialog is invoked (button, keyboard, etc.)
> >
> > Works great when I run it in debug in Qt though.
> >
> > Workaround is to use the skymap and click on the object you want. In
> > the scheduler enter some text in the object field (doesn't matter what) and
> > hit the + to use sky coordinates from the map.
> >
> > On Sat, 13 Aug 2022 at 10:05, Akarsh Simha <akarshsimha@gmail.com> wrote:
> >
> > >
> > >
> > > On Sat, Aug 13, 2022 at 01:27 Peter Amerl <pvamerl@gmail.com> wrote:
> > >
> > > > Hi All,
> > > > Has anyone else experienced an immediate crash when searching for
> > > > objects on a Mac using the Apple-f key combination?
> > > > I can confirm that it has worked in the past without a crash. Neither
> > > > Ctrl-f, nor selecting it from the menu appears to work for me at this time.
> > > > The Crash trace is appended in the zip if anyone wants to have a look.
> > > >
> > >
> > > Hi Peter
> > >
> > > When you say it worked in the past, could you provide the exact version
> > > / git commit, and also your current version / git commit that has the bug?
> > > I made several changes to the Find Dialog in the most recent version,
> > > notably performing asynchronous database queries through another thread. It
> > > never crashed on my Linux system. Also curious if someone else can
> > > reproduce it on MacOS or if it is unique to your system.
> > >
> > > Regards
> > > Akarsh
> > >
> > >
> > > > Cheers,
> > > > Peter
> > > >
> > > >
> > > >
> >
>
[Attachment #3 (text/html)]
<div dir="ltr">I received one report for Find Dialog crash as well on Raspberry Pi, so perhaps it's \
not unique to MacOS?<div><br></div><div>However, I couldn't reproduce on Raspberry PI, Widows, or \
any x86-64 machine.</div><div><br clear="all"><div><div dir="ltr" class="gmail_signature" \
data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>--</div><div>Best \
Regards,<br>Jasem Mutlaq<br></div><div><br></div></div></div></div></div></div><br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Aug 17, 2022 at 8:52 AM Robert Lancaster \
<<a href="mailto:rlancaste@gmail.com">rlancaste@gmail.com</a>> wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;">Ok I did some more \
testing.<div><br></div><div>This commit is when the Find Dialog broke when running KStars on MacOS by \
double clicking the app:</div><div><br></div><div><a \
href="https://github.com/KDE/kstars/commit/5a2ba9f8e8b275f44b7593a50ca66f09cb2f985d#diff-c2a2ab763404c18a2daee3feb8b31f2ec278034e7cc720870c4e5158081e0ee9" \
target="_blank">https://github.com/KDE/kstars/commit/5a2ba9f8e8b275f44b7593a50ca66f09cb2f985d#diff-c2a2ab7 \
63404c18a2daee3feb8b31f2ec278034e7cc720870c4e5158081e0ee9</a></div><div><br></div><div>I think that is \
the one you were hoping was not the one. I still don't know why it broke it though. Every time I run \
it from terminal or qt creator there is no problem. It is just when running it by double clicking that \
is the problem.</div><div><br></div><div>Note that I did test playing with the environment variables in \
qt creator and that seemed to have no effect. And it also didn't seem to matter whether kstars was \
packaged up or not, so it doesn't seem to be a packaging issue.<br><div><br><blockquote \
type="cite"><div>On Aug 16, 2022, at 2:11 PM, Akarsh Simha <<a href="mailto:akarshsimha@gmail.com" \
target="_blank">akarshsimha@gmail.com</a>> wrote:</div><br><div><div dir="auto">If I am to blame for \
this, the parallelism introduced in the asynchronous find dialog is my suspect, rather than the comet \
regex (which was actually Hy and not me). The regex seems unlikely to cause the erratic behavior Robert \
is observing where it runs fine under a debugger.</div><div dir="auto"><br></div><div dir="auto">But if \
it works fine when running KStars from a command line, that probably exonerates me and Hy, and is likely \
an environment issue like Robert points out!</div><div dir="auto"><br></div><div \
dir="auto">Regards</div><div dir="auto">Akarsh</div><div dir="auto"><br></div><div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 16, 2022 at 07:28 Robert Lancaster \
<<a href="mailto:rlancaste@gmail.com" target="_blank">rlancaste@gmail.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;">Hey guys,<div><br></div><div>I \
just got back from my two week trip to the Southwest. Yesterday I resolved the issue with building a \
dmg with my script, so now I can build DMGs that will work with older Macs and have all the features we \
want in the dmg. </div><div><br></div><div>Next we can look into this Find Dialog bug. I did some \
experiments today and I found that if I run kstars from the command line or in a debugger, the find \
dialog works fine, but when running the app by double clicking it crashes when you first access the find \
dialog. This seems to me to indicate an environment issue, like maybe an issue with environment \
variables or maybe a link to a library that isn't properly in the app. I will check \
further.</div><div><br></div><div>Thanks,</div><div><br></div><div>Rob</div></div><div \
style="overflow-wrap: break-word;"><div><div><br><blockquote type="cite"><div>On Aug 13, 2022, at 6:09 \
AM, John Evans <<a href="mailto:john.e.evans.email@gmail.com" \
target="_blank">john.e.evans.email@gmail.com</a>> wrote:</div><br><div><div dir="ltr">I have the same \
problem with 3.6.0. Crashes everytime the find object dialog is invoked (button, keyboard, \
etc.)<div><br></div><div>Works great when I run it in debug in Qt \
though.</div><div><br></div><div>Workaround is to use the skymap and click on the object you want. In the \
scheduler enter some text in the object field (doesn't matter what) and hit the + to use sky \
coordinates from the map.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On \
Sat, 13 Aug 2022 at 10:05, Akarsh Simha <<a href="mailto:akarshsimha@gmail.com" \
target="_blank">akarshsimha@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div><br></div><div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Sat, Aug 13, 2022 at 01:27 Peter Amerl <<a href="mailto:pvamerl@gmail.com" \
target="_blank">pvamerl@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi All, <br> Has \
anyone else experienced an immediate crash when searching for objects on a Mac using the Apple-f key \
combination?<br> I can confirm that it has worked in the past without a crash. Neither Ctrl-f, nor \
selecting it from the menu appears to work for me at this time. <br> The Crash trace is appended in the \
zip if anyone wants to have a look.<br> </blockquote><div dir="auto"><br></div><div dir="auto">Hi \
Peter</div><div dir="auto"><br></div><div dir="auto">When you say it worked in the past, could you \
provide the exact version / git commit, and also your current version / git commit that has the bug? I \
made several changes to the Find Dialog in the most recent version, notably performing asynchronous \
database queries through another thread. It never crashed on my Linux system. Also curious if someone \
else can reproduce it on MacOS or if it is unique to your system.</div><div dir="auto"><br></div><div \
dir="auto">Regards</div><div dir="auto">Akarsh</div><div dir="auto"><br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><br> Cheers, <br>
Peter <br>
<br>
<br>
</blockquote></div></div>
</blockquote></div>
</div></blockquote></div><br></div></div></blockquote></div></div>
</div></blockquote></div><br></div></div></blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic