[prev in list] [next in list] [prev in thread] [next in thread]
List: kstars-devel
Subject: Re: Kstars 3.6.0 MacOS find Object crash
From: Robert Lancaster <rlancaste () gmail ! com>
Date: 2022-08-17 5:51:43
Message-ID: AC44E650-9926-4A5B-A41D-1202B354163A () gmail ! com
[Download RAW message or body]
Ok I did some more testing.
This commit is when the Find Dialog broke when running KStars on MacOS by double clicking the app:
https://github.com/KDE/kstars/commit/5a2ba9f8e8b275f44b7593a50ca66f09cb2f985d#diff-c2a2ab763404c18a2daee3feb8b31f2ec278034e7cc720870c4e5158081e0ee9 \
<https://github.com/KDE/kstars/commit/5a2ba9f8e8b275f44b7593a50ca66f09cb2f985d#diff-c2a2ab763404c18a2daee3feb8b31f2ec278034e7cc720870c4e5158081e0ee9>
I think that is the one you were hoping was not the one. I still don't know why it broke it though. \
Every time I run it from terminal or qt creator there is no problem. It is just when running it by \
double clicking that is the problem.
Note that I did test playing with the environment variables in qt creator and that seemed to have no \
effect. And it also didn't seem to matter whether kstars was packaged up or not, so it doesn't seem to \
be a packaging issue.
> On Aug 16, 2022, at 2:11 PM, Akarsh Simha <akarshsimha@gmail.com> wrote:
>
> If I am to blame for this, the parallelism introduced in the asynchronous find dialog is my suspect, \
> rather than the comet regex (which was actually Hy and not me). The regex seems unlikely to cause the \
> erratic behavior Robert is observing where it runs fine under a debugger.
> But if it works fine when running KStars from a command line, that probably exonerates me and Hy, and \
> is likely an environment issue like Robert points out!
> Regards
> Akarsh
>
>
> On Tue, Aug 16, 2022 at 07:28 Robert Lancaster <rlancaste@gmail.com <mailto:rlancaste@gmail.com>> \
> wrote: Hey guys,
>
> I just got back from my two week trip to the Southwest. Yesterday I resolved the issue with building a \
> dmg with my script, so now I can build DMGs that will work with older Macs and have all the features we \
> want in the dmg.
> Next we can look into this Find Dialog bug. I did some experiments today and I found that if I run \
> kstars from the command line or in a debugger, the find dialog works fine, but when running the app by \
> double clicking it crashes when you first access the find dialog. This seems to me to indicate an \
> environment issue, like maybe an issue with environment variables or maybe a link to a library that \
> isn't properly in the app. I will check further.
> Thanks,
>
> Rob
>
> > On Aug 13, 2022, at 6:09 AM, John Evans <john.e.evans.email@gmail.com \
> > <mailto:john.e.evans.email@gmail.com>> wrote:
> > I have the same problem with 3.6.0. Crashes everytime the find object dialog is invoked (button, \
> > keyboard, etc.)
> > Works great when I run it in debug in Qt though.
> >
> > Workaround is to use the skymap and click on the object you want. In the scheduler enter some text in \
> > the object field (doesn't matter what) and hit the + to use sky coordinates from the map.
> > On Sat, 13 Aug 2022 at 10:05, Akarsh Simha <akarshsimha@gmail.com <mailto:akarshsimha@gmail.com>> \
> > wrote:
> >
> > On Sat, Aug 13, 2022 at 01:27 Peter Amerl <pvamerl@gmail.com <mailto:pvamerl@gmail.com>> wrote:
> > Hi All,
> > Has anyone else experienced an immediate crash when searching for objects on a Mac using the Apple-f \
> > key combination? I can confirm that it has worked in the past without a crash. Neither Ctrl-f, nor \
> > selecting it from the menu appears to work for me at this time. The Crash trace is appended in the \
> > zip if anyone wants to have a look.
> > Hi Peter
> >
> > When you say it worked in the past, could you provide the exact version / git commit, and also your \
> > current version / git commit that has the bug? I made several changes to the Find Dialog in the most \
> > recent version, notably performing asynchronous database queries through another thread. It never \
> > crashed on my Linux system. Also curious if someone else can reproduce it on MacOS or if it is unique \
> > to your system.
> > Regards
> > Akarsh
> >
> >
> > Cheers,
> > Peter
> >
> >
>
[Attachment #3 (unknown)]
<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body \
style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Ok I did \
some more testing.<div class=""><br class=""></div><div class="">This commit is when the Find Dialog \
broke when running KStars on MacOS by double clicking the app:</div><div class=""><br class=""></div><div \
class=""><a href="https://github.com/KDE/kstars/commit/5a2ba9f8e8b275f44b7593a50ca66f09cb2f985d#diff-c2a2ab763404c18a2daee3feb8b31f2ec278034e7cc720870c4e5158081e0ee9" \
class="">https://github.com/KDE/kstars/commit/5a2ba9f8e8b275f44b7593a50ca66f09cb2f985d#diff-c2a2ab763404c18a2daee3feb8b31f2ec278034e7cc720870c4e5158081e0ee9</a></div><div \
class=""><br class=""></div><div class="">I think that is the one you were hoping was not the one. \
I still don't know why it broke it though. Every time I run it from terminal or qt creator \
there is no problem. It is just when running it by double clicking that is the problem.</div><div \
class=""><br class=""></div><div class="">Note that I did test playing with the environment variables in \
qt creator and that seemed to have no effect. And it also didn't seem to matter whether kstars was \
packaged up or not, so it doesn't seem to be a packaging issue.<br class=""><div><br class=""><blockquote \
type="cite" class=""><div class="">On Aug 16, 2022, at 2:11 PM, Akarsh Simha <<a \
href="mailto:akarshsimha@gmail.com" class="">akarshsimha@gmail.com</a>> wrote:</div><br \
class="Apple-interchange-newline"><div class=""><div dir="auto" class="">If I am to blame for this, the \
parallelism introduced in the asynchronous find dialog is my suspect, rather than the comet regex (which \
was actually Hy and not me). The regex seems unlikely to cause the erratic behavior Robert is observing \
where it runs fine under a debugger.</div><div dir="auto" class=""><br class=""></div><div dir="auto" \
class="">But if it works fine when running KStars from a command line, that probably exonerates me and \
Hy, and is likely an environment issue like Robert points out!</div><div dir="auto" class=""><br \
class=""></div><div dir="auto" class="">Regards</div><div dir="auto" class="">Akarsh</div><div dir="auto" \
class=""><br class=""></div><div class=""><br class=""><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Tue, Aug 16, 2022 at 07:28 Robert Lancaster <<a \
href="mailto:rlancaste@gmail.com" class="">rlancaste@gmail.com</a>> wrote:<br \
class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div \
style="word-wrap:break-word;line-break:after-white-space" class="">Hey guys,<div class=""><br \
class=""></div><div class="">I just got back from my two week trip to the Southwest. Yesterday I \
resolved the issue with building a dmg with my script, so now I can build DMGs that will work with older \
Macs and have all the features we want in the dmg. </div><div class=""><br class=""></div><div \
class="">Next we can look into this Find Dialog bug. I did some experiments today and I found that \
if I run kstars from the command line or in a debugger, the find dialog works fine, but when running the \
app by double clicking it crashes when you first access the find dialog. This seems to me to \
indicate an environment issue, like maybe an issue with environment variables or maybe a link to a \
library that isn't properly in the app. I will check further.</div><div class=""><br \
class=""></div><div class="">Thanks,</div><div class=""><br class=""></div><div \
class="">Rob</div></div><div style="word-wrap:break-word;line-break:after-white-space" class=""><div \
class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Aug 13, 2022, at \
6:09 AM, John Evans <<a href="mailto:john.e.evans.email@gmail.com" target="_blank" \
class="">john.e.evans.email@gmail.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" \
class="">I have the same problem with 3.6.0. Crashes everytime the find object dialog is invoked \
(button, keyboard, etc.)<div class=""><br class=""></div><div class="">Works great when I run it in debug \
in Qt though.</div><div class=""><br class=""></div><div class="">Workaround is to use the skymap and \
click on the object you want. In the scheduler enter some text in the object field (doesn't matter \
what) and hit the + to use sky coordinates from the map.</div></div><br class=""><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, 13 Aug 2022 at 10:05, Akarsh Simha <<a \
href="mailto:akarshsimha@gmail.com" target="_blank" class="">akarshsimha@gmail.com</a>> wrote:<br \
class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><div \
class=""><br class=""></div><div class=""><br class=""><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Sat, Aug 13, 2022 at 01:27 Peter Amerl <<a href="mailto:pvamerl@gmail.com" \
target="_blank" class="">pvamerl@gmail.com</a>> wrote:<br class=""></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">Hi \
All, <br class=""> Has anyone else experienced an immediate crash when searching for objects on a Mac \
using the Apple-f key combination?<br class=""> I can confirm that it has worked in the past without a \
crash. Neither Ctrl-f, nor selecting it from the menu appears to work for me at this time. <br class=""> \
The Crash trace is appended in the zip if anyone wants to have a look.<br class=""> </blockquote><div \
dir="auto" class=""><br class=""></div><div dir="auto" class="">Hi Peter</div><div dir="auto" \
class=""><br class=""></div><div dir="auto" class="">When you say it worked in the past, could you \
provide the exact version / git commit, and also your current version / git commit that has the \
bug? I made several changes to the Find Dialog in the most recent version, notably performing \
asynchronous database queries through another thread. It never crashed on my Linux system. Also curious \
if someone else can reproduce it on MacOS or if it is unique to your system.</div><div dir="auto" \
class=""><br class=""></div><div dir="auto" class="">Regards</div><div dir="auto" \
class="">Akarsh</div><div dir="auto" class=""><br class=""></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)"><br \
class=""> Cheers, <br class="">
Peter <br class="">
<br class="">
<br class="">
</blockquote></div></div>
</blockquote></div>
</div></blockquote></div><br class=""></div></div></blockquote></div></div>
</div></blockquote></div><br class=""></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic