[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    Re: but in stellarsolver
From:       Jasem Mutlaq <mutlaqja () ikarustech ! com>
Date:       2021-07-24 11:15:58
Message-ID: CAE0bU5=XNcq_RsKrYGQmP_Y3fJ0-z3u399qT4R4sikNdC36_fw () mail ! gmail ! com
[Download RAW message or body]

Hello Hy,

The change you proposed affects the code meant for "Load and Slew", so
perhaps not the bug you are referring to?

--
Best Regards,
Jasem Mutlaq


On Sat, Jul 24, 2021 at 8:15 AM Hy Murveit <murveit@gmail.com> wrote:
> 
> OK, how about this one (in align.cpp):
> 
> https://invent.kde.org/education/kstars/-/blob/master/kstars/ekos/align/align.cpp#L3401
> It seems to me that this would make use use the scale, even if 'use scale' was disabled in the UI
> Shouldn't it be instead:
> 
> if (solution.pixscale > 0 && Options::astrometryUseImageScale())
> m_StellarSolver->setSearchScale(solution.pixscale * 0.8,
> solution.pixscale * 1.2,
> SSolver::ARCSEC_PER_PIX);
> else
> m_StellarSolver->setProperty("UseScale", false);
> 
> and ditto for position.
> 
> I know something is turning on scale behind my back.
> Hy
> 
> PS the reason I'm concerned about turning on/off scale, is that it can cause ASTAP to fail.
> I previously mentioned another bug/inconsistency, where ASTAP expects the scale to be the height scale, \
> but ekos/stellarsolver is sending ASTAP the width scale. ASTAP doesn't really need scale, works fine \
> without it, so I tend to use that without scale, but now and then the scale gets turned back on. 
> 
> 
> On Fri, Jul 23, 2021 at 8:55 PM Robert Lancaster <rlancaste@gmail.com> wrote:
> > 
> > I just took a look.  That code is in the parallel solving section in the algorithm that uses multiple \
> > scales, meaning that this code should execute when use scale is OFF.  Then what it does is spawn \
> > multiple parallel solvers each of which will have a different search scale and will have use scale \
> > ON.  So yes that will work as intended. It will not turn use scale back on for the overall solve, but \
> > for the child solvers, each of them has use scale turned on but at a different scale. 
> > Sent from my iPhone
> > 
> > On Jul 23, 2021, at 11:31 PM, Hy Murveit <murveit@gmail.com> wrote:
> > 
> > 
> > I think I've identified a bug in stellarsolver.
> > Please see line 326 is stellarsolver.cpp
> > https://github.com/rlancaste/stellarsolver/blob/master/stellarsolver/stellarsolver.cpp#L326
> > 
> > It says:
> > > 
> > > solver->setSearchScale(low, high, units);
> > 
> > I believe it should say:
> > > 
> > > if (m_UseScale) solver->setSearchScale(low, high, units);
> > 
> > 
> > The reason this is important is that setSearchScale has a side-effect of setting m_UseScale = true.
> > 
> > I've seen several times when I've turned off UseScale, and then I've found UseScale magically turned \
> > back on later. 
> > I didn't want to put in an MR on stellarsolver, as I wanted you to double check this, Rob or Jasem. \
> > Please let me know if you fix this, or if you want me to send you a github MR. 
> > Hy


[prev in list] [next in list] [prev in thread] [next in thread]