[prev in list] [next in list] [prev in thread] [next in thread]
List: kstars-devel
Subject: Re: [Kstars-devel] Review Request 112496: Column for Object 2 is added in conjunctions tool and defa
From: "Vijay Dhameliya" <vijay.atwork13 () gmail ! com>
Date: 2013-12-29 22:47:27
Message-ID: 20131229224727.21904.50897 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 14, 2013, 9:17 p.m., Rafal Kulaga wrote:
> > kstars/tools/conjunctions.cpp, line 387
> > <https://git.reviewboard.kde.org/r/112496/diff/4/?file=189402#file189402line387>
> >
> > Stray WS
Changes are made accordingly, now :)
- Vijay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112496/#review40031
-----------------------------------------------------------
On Sept. 29, 2013, 6:22 a.m., Vijay Dhameliya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112496/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2013, 6:22 a.m.)
>
>
> Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal \
> Kulaga.
>
> Repository: kstars
>
>
> Description
> -------
>
> In conjunctions tool default width of column in text box is set large enough to \
> make it look better and column "object 2" is added to keep log of to which object \
> the object 1 is mapping, when we have calculated many conjunctions from same \
> object 1 to different object 2s.
>
> Diffs
> -----
>
> kstars/kstarsinit.cpp a4393e6
> kstars/tools/conjunctions.h b51209e
> kstars/tools/conjunctions.cpp 39cef00
> kstars/tools/conjunctions.ui 80374b1
>
> Diff: https://git.reviewboard.kde.org/r/112496/diff/
>
>
> Testing
> -------
>
> tested
>
>
> File Attachments
> ----------------
>
>
> https://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_after.png
>
> https://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_Before.png
>
>
> Thanks,
>
> Vijay Dhameliya
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/112496/">https://git.reviewboard.kde.org/r/112496/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 14th, 2013, 9:17 p.m. UTC, <b>Rafal \
Kulaga</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/112496/diff/4/?file=189402#file189402line387" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/tools/conjunctions.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ConjunctionsTool::showConjunctions(const QMap<long double, dms> \
&conjunctionlist, QString object)</pre></td> <td colspan="2"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ConjunctionsTool::showConjunctions(const QMap<long double, dms> \
&conjunctionlist,const QString object1,const QString object2)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">387</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o"><<</span> <span class="k">new</span> <span \
class="n">QStandardItem</span><span class="p">(</span> <span \
class="n">KGlobal</span><span class="o">::</span><span class="n">locale</span><span \
class="p">()</span><span class="o">-></span><span \
class="n">formatDateTime</span><span class="p">(</span> <span \
class="n">dt</span><span class="p">,</span> <span class="n">KLocale</span><span \
class="o">::</span><span class="n">IsoDate</span> <span class="p">)</span> <span \
class="p">)</span><span class="ew"> </span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">387</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o"><<</span> <span class="k">new</span> <span \
class="n">QStandardItem</span><span class="p">(</span> <span \
class="n">KGlobal</span><span class="o">::</span><span class="n">locale</span><span \
class="p">()</span><span class="o">-></span><span \
class="n">formatDateTime</span><span class="p">(</span> <span \
class="n">dt</span><span class="p">,</span> <span class="n">KLocale</span><span \
class="o">::</span><span class="n">IsoDate</span> <span class="p">)</span> <span \
class="p">)</span><span class="ew"> </span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stray WS</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes are \
made accordingly, now :)</pre> <br />
<p>- Vijay</p>
<br />
<p>On September 29th, 2013, 6:22 a.m. UTC, Vijay Dhameliya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal \
Kulaga.</div> <div>By Vijay Dhameliya.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2013, 6:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In conjunctions tool default width of column in text box is set large \
enough to make it look better and column "object 2" is added to keep log of \
to which object the object 1 is mapping, when we have calculated many conjunctions \
from same object 1 to different object 2s.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/kstarsinit.cpp <span style="color: grey">(a4393e6)</span></li>
<li>kstars/tools/conjunctions.h <span style="color: grey">(b51209e)</span></li>
<li>kstars/tools/conjunctions.cpp <span style="color: grey">(39cef00)</span></li>
<li>kstars/tools/conjunctions.ui <span style="color: grey">(80374b1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/112496/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_after.png">Conjunction_tool_after.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_Before.png">Conjunction_tool_Before.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic