'Re: [Kstars-devel] Review Request 112667: Add solar/lunar eclipse button to conjunction tool'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    Re: [Kstars-devel] Review Request 112667: Add solar/lunar eclipse button to conjunction tool
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2013-12-29 19:50:24
Message-ID: 20131229195024.21905.11153 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112667/#review46410
-----------------------------------------------------------

KStars guys, can you have a look at this?

- Albert Astals Cid

On Oct. 18, 2013, 1:50 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112667/
> -----------------------------------------------------------
> 
> Review request for KDE Edu, KStars and Akarsh Simha.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Add solar/lunar eclipse button to conjunctions tool for better usability 
> 
> 
> Diffs
> -----
> 
>   kstars/skyobjects/skypoint.cpp f634075 
>   kstars/tools/conjunctions.h b51209e 
>   kstars/tools/conjunctions.cpp 39cef00 
>   kstars/tools/conjunctions.ui 80374b1 
>   kstars/tools/skycalendar.cpp 3ca61de 
> 
> Diff: https://git.reviewboard.kde.org/r/112667/diff/
> 
> 
> Testing
> -------
> 
> Tested , it predicts correct dates of eclipse but some eclipse may not get displayed
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/112667/">https://git.reviewboard.kde.org/r/112667/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KStars guys, can you \
have a look at this?</pre>  <br />

<p>- Albert Astals Cid</p>

<br />
<p>On October 18th, 2013, 1:50 p.m. UTC, Vijay Dhameliya wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu, KStars and Akarsh Simha.</div>
<div>By Vijay Dhameliya.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add solar/lunar eclipse button to conjunctions tool for better usability \
</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested , it predicts correct dates of eclipse but some eclipse may not \
get displayed</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/skyobjects/skypoint.cpp <span style="color: grey">(f634075)</span></li>

 <li>kstars/tools/conjunctions.h <span style="color: grey">(b51209e)</span></li>

 <li>kstars/tools/conjunctions.cpp <span style="color: grey">(39cef00)</span></li>

 <li>kstars/tools/conjunctions.ui <span style="color: grey">(80374b1)</span></li>

 <li>kstars/tools/skycalendar.cpp <span style="color: grey">(3ca61de)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/112667/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

[prev in list] [next in list] [prev in thread] [next in thread] 