'Re: [Kstars-devel] Review Request 113438: Fixing bug in CometsComponent::draw()'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kstars-devel
Subject:    Re: [Kstars-devel] Review Request 113438: Fixing bug in CometsComponent::draw()
From:       "Vijay Dhameliya" <vijay.atwork13 () gmail ! com>
Date:       2013-12-24 3:40:12
Message-ID: 20131224034012.4833.11057 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113438/
-----------------------------------------------------------

(Updated Dec. 24, 2013, 3:40 a.m.)

Status
------

This change has been marked as submitted.

Review request for KStars, Henry de Valence, Rafal Kulaga, and Rishab Arora.

Bugs: 326647
    http://bugs.kde.org/show_bug.cgi?id=326647

Repository: kstars

Description
-------

Bug:
->Since sortMagnitude for comet is never set, calling mag() in draw class returns NaN \
which causes crashes while zooming on KSComet object.  
Fixing:
-> Drawing KSComet on the basis of Total Magnitude Parameter

Diffs
-----

  kstars/dialogs/detaildialog.cpp efda624 
  kstars/skycomponents/cometscomponent.cpp 395c856 

Diff: https://git.reviewboard.kde.org/r/113438/diff/

Testing
-------

Bug fixed - No more crashing 

Thanks,

Vijay Dhameliya

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/113438/">https://git.reviewboard.kde.org/r/113438/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KStars, Henry de Valence, Rafal Kulaga, and Rishab \
Arora.</div> <div>By Vijay Dhameliya.</div>

<p style="color: grey;"><i>Updated Dec. 24, 2013, 3:40 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=326647">326647</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">Bug:
-&gt;Since sortMagnitude for comet is never set, calling mag() in draw class returns \
NaN which causes crashes while zooming on KSComet object.  
Fixing:
-&gt; Drawing KSComet on the basis of Total Magnitude Parameter</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Bug fixed - No more crashing </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/dialogs/detaildialog.cpp <span style="color: grey">(efda624)</span></li>

 <li>kstars/skycomponents/cometscomponent.cpp <span style="color: \
grey">(395c856)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/113438/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kstars-devel mailing list
Kstars-devel@kde.org
https://mail.kde.org/mailman/listinfo/kstars-devel

[prev in list] [next in list] [prev in thread] [next in thread] 