From kstars-devel Tue Dec 24 03:40:12 2013 From: "Vijay Dhameliya" Date: Tue, 24 Dec 2013 03:40:12 +0000 To: kstars-devel Subject: Re: [Kstars-devel] Review Request 113438: Fixing bug in CometsComponent::draw() Message-Id: <20131224034012.4833.11057 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kstars-devel&m=138785642805700 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2369859834474533677==" --===============2369859834474533677== Content-Type: multipart/alternative; boundary="===============5347086917214960785==" --===============5347086917214960785== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113438/ ----------------------------------------------------------- (Updated Dec. 24, 2013, 3:40 a.m.) Status ------ This change has been marked as submitted. Review request for KStars, Henry de Valence, Rafal Kulaga, and Rishab Arora. Bugs: 326647 http://bugs.kde.org/show_bug.cgi?id=326647 Repository: kstars Description ------- Bug: ->Since sortMagnitude for comet is never set, calling mag() in draw class returns NaN which causes crashes while zooming on KSComet object. Fixing: -> Drawing KSComet on the basis of Total Magnitude Parameter Diffs ----- kstars/dialogs/detaildialog.cpp efda624 kstars/skycomponents/cometscomponent.cpp 395c856 Diff: https://git.reviewboard.kde.org/r/113438/diff/ Testing ------- Bug fixed - No more crashing Thanks, Vijay Dhameliya --===============5347086917214960785== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113438/

This change has been marked as submitted.

Review request for KStars, Henry de Valence, Rafal Kulaga, and Rishab Arora.

By Vijay Dhameliya.

Updated Dec. 24, 2013, 3:40 a.m.

Bugs: 326647

Repository: kstars

Description

Bug:
->Since sortMagnitude for comet is never set, calling mag() in draw class returns NaN which causes crashes while zooming on KSComet object.
 
Fixing:
-> Drawing KSComet on the basis of Total Magnitude Parameter

Testing

Bug fixed - No more crashing

Diffs

kstars/dialogs/detaildialog.cpp (efda624)
kstars/skycomponents/cometscomponent.cpp (395c856)

View Diff

--===============5347086917214960785==-- --===============2369859834474533677== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kstars-devel mailing list Kstars-devel@kde.org https://mail.kde.org/mailman/listinfo/kstars-devel --===============2369859834474533677==--