[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Bugs in pidgin history import for kopete
From: Pali_Rohár <pali.rohar () gmail ! com>
Date: 2012-02-27 21:35:49
Message-ID: 20120227213549.15113.10708 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 2, 2011, 12:20 a.m., Bartosz Brachaczek wrote:
> > Hi. If you want, I think you could also integrate changes from my old patch \
> > available here: http://reviewboard.kde.org/r/2334/.
>
> Timo Schlüßler wrote:
> Oh, of course. As soon as I find some free time :) (probably next sunday).
> Is it a bad sign that your review request is pending now since over one year? Is \
> there nobody to commit it?
> Cyberbeat wrote:
> I really would like to see this patch going into trunk
@Bartosz Brachaczek
@Timo Schlüßler
What is state of both patches?
https://svn.reviewboard.kde.org/r/6561/
https://svn.reviewboard.kde.org/r/2334/
- Pali
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6561/#review9925
-----------------------------------------------------------
On Feb. 28, 2011, 11:56 a.m., Timo Schlüßler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6561/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2011, 11:56 a.m.)
>
>
> Review request for Kopete.
>
>
> Description
> -------
>
> Fixes bugs from http://bugs.kde.org/show_bug.cgi?id=109942 in history import \
> feature from kopete:
> - Different protocol names in pidgin and kopete (e.g. msn => WlmProtocol)
> - Wrong text encoding for .txt import, set to utf-8 using QTextStream now
> - Unneccessarily often asked question if a given nickname is one that the
> user used at some time.
>
>
> This addresses bug http://bugs.kde.org/show_bug.cgi?id=109942.
> https://bugs.kde.org/show_bug.cgi?id=http://bugs.kde.org/show_bug.cgi?id=109942
>
>
> Diffs
> -----
>
> trunk/KDE/kdenetwork/kopete/plugins/history/historyimport.cpp 1222987
> trunk/KDE/kdenetwork/kopete/plugins/history/historyimport.h 1222987
>
> Diff: http://svn.reviewboard.kde.org/r/6561/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Timo Schlüßler
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6561/">http://svn.reviewboard.kde.org/r/6561/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 2nd, 2011, 12:20 a.m., <b>Bartosz \
Brachaczek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi. If you want, I think you could also integrate changes from my old \
patch available here: http://reviewboard.kde.org/r/2334/.</pre> </blockquote>
<p>On March 2nd, 2011, 1:14 a.m., <b>Timo Schlüßler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, of course. As soon \
as I find some free time :) (probably next sunday). Is it a bad sign that your review \
request is pending now since over one year? Is there nobody to commit it?</pre> \
</blockquote>
<p>On November 9th, 2011, 2:12 p.m., <b>Cyberbeat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I really would like to \
see this patch going into trunk</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Bartosz Brachaczek \
@Timo Schlüßler
What is state of both patches?
https://svn.reviewboard.kde.org/r/6561/
https://svn.reviewboard.kde.org/r/2334/</pre>
<br />
<p>- Pali</p>
<br />
<p>On February 28th, 2011, 11:56 a.m., Timo Schlüßler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Timo Schlüßler.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2011, 11:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes bugs from http://bugs.kde.org/show_bug.cgi?id=109942 in history \
import feature from kopete:
- Different protocol names in pidgin and kopete (e.g. msn => WlmProtocol)
- Wrong text encoding for .txt import, set to utf-8 using QTextStream now
- Unneccessarily often asked question if a given nickname is one that the
user used at some time.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=http://bugs.kde.org/show_bug.cgi?id=109942">http://bugs.kde.org/show_bug.cgi?id=109942</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdenetwork/kopete/plugins/history/historyimport.cpp <span \
style="color: grey">(1222987)</span></li>
<li>trunk/KDE/kdenetwork/kopete/plugins/history/historyimport.h <span style="color: \
grey">(1222987)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6561/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic