From kopete-devel Mon Feb 27 21:35:49 2012 From: =?utf-8?q?Pali_Roh=C3=A1r?= Date: Mon, 27 Feb 2012 21:35:49 +0000 To: kopete-devel Subject: Re: Review Request: Bugs in pidgin history import for kopete Message-Id: <20120227213549.15113.10708 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kopete-devel&m=133037859512656 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3075048230614354905==" --===============3075048230614354905== Content-Type: multipart/alternative; boundary="===============2056697452866964483==" --===============2056697452866964483== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On March 2, 2011, 12:20 a.m., Bartosz Brachaczek wrote: > > Hi. If you want, I think you could also integrate changes from my old p= atch available here: http://reviewboard.kde.org/r/2334/. > = > Timo Schl=C3=BC=C3=9Fler wrote: > Oh, of course. As soon as I find some free time :) (probably next sun= day). > Is it a bad sign that your review request is pending now since over o= ne year? Is there nobody to commit it? > = > Cyberbeat wrote: > I really would like to see this patch going into trunk @Bartosz Brachaczek @Timo Schl=C3=BC=C3=9Fler What is state of both patches? https://svn.reviewboard.kde.org/r/6561/ https://svn.reviewboard.kde.org/r/2334/ - Pali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6561/#review9925 ----------------------------------------------------------- On Feb. 28, 2011, 11:56 a.m., Timo Schl=C3=BC=C3=9Fler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6561/ > ----------------------------------------------------------- > = > (Updated Feb. 28, 2011, 11:56 a.m.) > = > = > Review request for Kopete. > = > = > Description > ------- > = > Fixes bugs from http://bugs.kde.org/show_bug.cgi?id=3D109942 in history i= mport feature from kopete: > - Different protocol names in pidgin and kopete (e.g. msn =3D> Wl= mProtocol) > - Wrong text encoding for .txt import, set to utf-8 using QTextSt= ream now > - Unneccessarily often asked question if a given nickname is one = that the = > user used at some time. > = > = > This addresses bug http://bugs.kde.org/show_bug.cgi?id=3D109942. > https://bugs.kde.org/show_bug.cgi?id=3Dhttp://bugs.kde.org/show_bug.c= gi?id=3D109942 > = > = > Diffs > ----- > = > trunk/KDE/kdenetwork/kopete/plugins/history/historyimport.cpp 1222987 = > trunk/KDE/kdenetwork/kopete/plugins/history/historyimport.h 1222987 = > = > Diff: http://svn.reviewboard.kde.org/r/6561/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Timo Schl=C3=BC=C3=9Fler > = > --===============2056697452866964483== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6561/

On March 2nd, 2011, 12:20 a.m., Bartosz Bra= chaczek wrote:

Hi. If yo=
u want, I think you could also integrate changes from my old patch availabl=
e here: http://reviewboard.kde.org/r/2334/.

On March 2nd, 2011, 1:14 a.m., Timo Schl=C3=BC=C3=9Fler wrote: 

Oh, of co=
urse. As soon as I find some free time :) (probably next sunday).
Is it a bad sign that your review request is pending now since over one yea=
r? Is there nobody to commit it?

On November 9th, 2011, 2:12 p.m., Cyberbeat wrote:

I really =
would like to see this patch going into trunk
@Bartosz Br=
achaczek
@Timo Schl=C3=BC=C3=9Fler

What is state of both patches?
https://svn.reviewboard.kde.org/r/6561/
https://svn.reviewboard.kde.org/r/2334/

- Pali


On February 28th, 2011, 11:56 a.m., Timo Schl=C3=BC=C3=9Fler wrote:

Review request for Kopete.
By Timo Schl=C3=BC=C3=9Fler.

Updated Feb. 28, 2011, 11:56 a.m.

Descripti= on 

Fixes bugs from http://bugs.kde.org/show_bug.cgi?id=3D109942=
 in history import feature from kopete:
        - Different protocol names in pidgin and kopete (e.g. msn =3D> W=
lmProtocol)
        - Wrong text encoding for .txt import, set to utf-8 using QTextStre=
am now
        - Unneccessarily often asked question if a given nickname is one th=
at the =

user used at some time.

Diffs=

  • trunk/KDE/kdenetwork/kopete/plugins/history/historyimport.cpp (1222987)
  • trunk/KDE/kdenetwork/kopete/plugins/history/historyimport.h (1222987)

View Diff
--===============2056697452866964483==-- --===============3075048230614354905== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel --===============3075048230614354905==--