[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: allows kopete to set the mood in skype
From: "Lamarque Souza" <lamarque () gmail ! com>
Date: 2011-03-02 22:44:35
Message-ID: 20110302224435.20158.13468 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 21, 2010, 3:06 p.m., Pali Rohár wrote:
> > Can you backport it to 4.4?
>
> Alin M Elena wrote:
> The patch should work without problems. I do not know who can commit it to the \
> branch... Probably would be faster to speak with the distribution people... I \
> really do not know what to do... Roman do you have any thoughts about?
> Alin
>
> Matt Rogers wrote:
> this seems like a new feature to me, and as such, we won't backport it, as stable \
> branches are bugfixes only.
Alin M Elena, please close this review request since it is already applied.
- Lamarque
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/2534/#review3772
-----------------------------------------------------------
On Jan. 18, 2010, 10:29 p.m., Alin M Elena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/2534/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2010, 10:29 p.m.)
>
>
> Review request for Kopete.
>
>
> Summary
> -------
>
> enhances skype wrapper and permits kopete to set the profile mood (status message) \
> for skype
>
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=221535.
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=221535
>
>
> Diffs
> -----
>
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.h \
> 1070407 svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.cpp \
> 1070407 svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/skypeaccount.cpp \
> 1070407
> Diff: http://svn.reviewboard.kde.org/r/2534/diff
>
>
> Testing
> -------
>
> I have tested on linux, opensuse 11.2 with kde 4.3.87
> tested different manually set profiles Online, Away, Busy...
> and the now listen plugin too.
> All seem to work...
>
>
> Thanks,
>
> Alin M
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/2534/">http://svn.reviewboard.kde.org/r/2534/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 21st, 2010, 3:06 p.m., <b>Pali \
Rohár</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Can you backport it to 4.4?</pre> </blockquote>
<p>On January 21st, 2010, 3:12 p.m., <b>Alin M Elena</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch should work \
without problems. I do not know who can commit it to the branch... Probably would be \
faster to speak with the distribution people... I really do not know what to do... \
Roman do you have any thoughts about?
Alin</pre>
</blockquote>
<p>On February 26th, 2010, 5:53 p.m., <b>Matt Rogers</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this seems like a new \
feature to me, and as such, we won't backport it, as stable branches are bugfixes \
only.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Alin M Elena, please \
close this review request since it is already applied.</pre> <br />
<p>- Lamarque</p>
<br />
<p>On January 18th, 2010, 10:29 p.m., Alin M Elena wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Alin M Elena.</div>
<p style="color: grey;"><i>Updated Jan. 18, 2010, 10:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">enhances skype wrapper and permits kopete to set the profile mood \
(status message) for skype</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have tested on linux, opensuse 11.2 with kde 4.3.87 tested different \
manually set profiles Online, Away, Busy... and the now listen plugin too.
All seem to work...</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=221535">https://bugs.kde.org/show_bug.cgi?id=221535</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.h \
<span style="color: grey">(1070407)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.cpp \
<span style="color: grey">(1070407)</span></li>
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdenetwork/kopete/protocols/skype/skypeaccount.cpp \
<span style="color: grey">(1070407)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/2534/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic