[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: Statistics: batch status updated on exit into a
From: "Lamarque Souza" <lamarque () gmail ! com>
Date: 2011-03-02 22:12:20
Message-ID: 20110302221220.18219.9073 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 23, 2010, 12:06 p.m., Raphael Kubo da Costa wrote:
> > Remember to backport to the 4.5 and 4.6 branches, and close any related=
bug reports.
Patch commited. Please close this review request.
- Lamarque
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5629/#review9393
-----------------------------------------------------------
On Oct. 14, 2010, 2:44 p.m., Luca Tettamanti wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5629/
> -----------------------------------------------------------
> =
> (Updated Oct. 14, 2010, 2:44 p.m.)
> =
> =
> Review request for Kopete.
> =
> =
> Summary
> -------
> =
> Statistics: batch status updated on exit into a single transaction.
> Upon exit Kopete will update the online status of all the contacts to "Un=
known"; this triggers an INSERT for each contact into the
> statistics DB which - with the default auto-commit behaviour - results in=
a fsync of the DB.
> A micro-benchmark shows that 500 (about the size of my contact list) INSE=
RTs take about 45 seconds on a not-so-crappy SATA disk, while the same amou=
nt of INSERTs batched into a single transaction take around 250ms.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticsdb.h 1185866 =
> trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticsdb.cpp 1185866 =
> trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticsplugin.h 11858=
66 =
> trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticsplugin.cpp 118=
5866 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5629/diff
> =
> =
> Testing
> -------
> =
> Shutdown and check that the expected data is in the DB.
> =
> =
> Thanks,
> =
> Luca
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5629/">http://svn.reviewboard.kde.org/r/5629/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 23rd, 2010, 12:06 p.m., <b>Raphael \
Kubo da Costa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remember to backport to the 4.5 and 4.6 branches, and close any related \
bug reports.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch commited. Please \
close this review request.</pre> <br />
<p>- Lamarque</p>
<br />
<p>On October 14th, 2010, 2:44 p.m., Luca Tettamanti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Luca Tettamanti.</div>
<p style="color: grey;"><i>Updated Oct. 14, 2010, 2:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Statistics: batch status updated on exit into a single transaction. Upon \
exit Kopete will update the online status of all the contacts to "Unknown"; \
this triggers an INSERT for each contact into the statistics DB which - with the \
default auto-commit behaviour - results in a fsync of the DB. A micro-benchmark shows \
that 500 (about the size of my contact list) INSERTs take about 45 seconds on a \
not-so-crappy SATA disk, while the same amount of INSERTs batched into a single \
transaction take around 250ms.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Shutdown and check that the expected data is in the DB.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticsdb.h <span \
style="color: grey">(1185866)</span></li>
<li>trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticsdb.cpp <span \
style="color: grey">(1185866)</span></li>
<li>trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticsplugin.h <span \
style="color: grey">(1185866)</span></li>
<li>trunk/KDE/kdenetwork/kopete/plugins/statistics/statisticsplugin.cpp <span \
style="color: grey">(1185866)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5629/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic