[prev in list] [next in list] [prev in thread] [next in thread]
List: kopete-devel
Subject: Re: Review Request: video support for FreeBSD
From: "Raphael Kubo da Costa" <kubito () gmail ! com>
Date: 2010-11-01 22:26:31
Message-ID: 20101101222631.23189.94668 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5750/#review8468
-----------------------------------------------------------
Ship it!
Looks OK to me. It might be good to hear from Frank Schaeffer first, though=
(I hope he's still around). In the future, it should be better to remove m=
ost of the OS checks and rely solely on ENABLE_AV being set correctly.
- Raphael
On 2010-11-01 22:07:53, Max Brazhnikov wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5750/
> -----------------------------------------------------------
> =
> (Updated 2010-11-01 22:07:53)
> =
> =
> Review request for Kopete.
> =
> =
> Summary
> -------
> =
> Trivial patch to enable video support on FreeBSD via v4l compatibility.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.h 1192069 =
> trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.cpp 1192069 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5750/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Max
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5750/">http://svn.reviewboard.kde.org/r/5750/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks OK to me. It might \
be good to hear from Frank Schaeffer first, though (I hope he's still around). In \
the future, it should be better to remove most of the OS checks and rely solely on \
ENABLE_AV being set correctly.</pre> <br />
<p>- Raphael</p>
<br />
<p>On November 1st, 2010, 10:07 p.m., Max Brazhnikov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kopete.</div>
<div>By Max Brazhnikov.</div>
<p style="color: grey;"><i>Updated 2010-11-01 22:07:53</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Trivial patch to enable video support on FreeBSD via v4l \
compatibility.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.h <span style="color: \
grey">(1192069)</span></li>
<li>trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.cpp <span \
style="color: grey">(1192069)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5750/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic