--===============0706830641== Content-Type: multipart/alternative; boundary="===============1852735041718743890==" --===============1852735041718743890== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5750/#review8468 ----------------------------------------------------------- Ship it! Looks OK to me. It might be good to hear from Frank Schaeffer first, though= (I hope he's still around). In the future, it should be better to remove m= ost of the OS checks and rely solely on ENABLE_AV being set correctly. - Raphael On 2010-11-01 22:07:53, Max Brazhnikov wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5750/ > ----------------------------------------------------------- > = > (Updated 2010-11-01 22:07:53) > = > = > Review request for Kopete. > = > = > Summary > ------- > = > Trivial patch to enable video support on FreeBSD via v4l compatibility. > = > = > Diffs > ----- > = > trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.h 1192069 = > trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.cpp 1192069 = > = > Diff: http://svn.reviewboard.kde.org/r/5750/diff > = > = > Testing > ------- > = > = > Thanks, > = > Max > = > --===============1852735041718743890== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5750/

Ship it!

Looks OK t=
o me. It might be good to hear from Frank Schaeffer first, though (I hope h=
e's still around). In the future, it should be better to remove most of=
 the OS checks and rely solely on ENABLE_AV being set correctly.

- Raphael

On November 1st, 2010, 10:07 p.m., Max Brazhnikov wrote:

Review request for Kopete.

By Max Brazhnikov.

Updated 2010-11-01 22:07:53

Descripti= on

Trivial patch to enable video support on FreeBSD via v4l com=
patibility.

Diffs=

trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.h (1192069)
trunk/KDE/kdenetwork/kopete/libkopete/avdevice/videodevice.cpp (1192069)

View Diff

--===============1852735041718743890==-- --===============0706830641== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel --===============0706830641==--