[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: Add an "exists" method to
From:       "Matt Rogers" <mattr () kde ! org>
Date:       2009-09-11 18:03:24
Message-ID: 20090911180324.14381.68015 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1532/#review2291
-----------------------------------------------------------

Ship it!


For me, the code looks fine, but I don't know a lot about the new avatar manager \
stuff. If you already have a use case for this that can't be solved some other way, \
then I say commit.

- Matt


On 2009-09-07 15:42:34, Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1532/
> -----------------------------------------------------------
> 
> (Updated 2009-09-07 15:42:34)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> Add an exists method to check if an avatarEntry exists. They (both) looks like:
> bool exists(Kopete::AvatarManager::AvatarEntry avatarToCheck)
> bool exists(const Qstring &avatarName)
> 
> Currently the methods don't check if the data exists, only the KConfigGroup. I \
> thought, which in case that I have to check it too, if one of them doesn't exist, I \
> should return "false" and remove the rest of the component. An I right? 
> I have a couple of questions that only a kopete developer can answer:
> 1-Should I add an alias which takes a path as argument?
> 2-Should I check if the data exists?
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdenetwork/kopete/libkopete/kopeteavatarmanager.cpp 1020689 
> trunk/KDE/kdenetwork/kopete/libkopete/kopeteavatarmanager.h 1020689 
> 
> Diff: http://reviewboard.kde.org/r/1532/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex
> 
> 

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]