[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: fix autoscroll when it shouldn't
From:       "Matt Rogers" <mattr () kde ! org>
Date:       2009-03-20 12:54:33
Message-ID: 20090320125433.24883.20456 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/353/#review531
-----------------------------------------------------------

Ship it!


please commit.

- Matt


On 2009-03-17 22:32:47, Benson Tsai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/353/
> -----------------------------------------------------------
> 
> (Updated 2009-03-17 22:32:47)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> When you scroll using the mouse wheel the scrollPressed variable should be updated \
> accordingly. This is accomplished by listening for valueChanged instead of \
> sliderMoved since sliderMoved only gets emitted when the user drags the slider \
> around and not on mouse wheel events. valueChanged on the other hand can be set to \
> be emitted whenever the slider changed by setting tracking to true.  
> 
> Diffs
> -----
> 
> /trunk/KDE/kdenetwork/kopete/kopete/chatwindow/chatmessagepart.cpp 939441 
> 
> Diff: http://reviewboard.kde.org/r/353/diff
> 
> 
> Testing
> -------
> 
> Tested locally, appears to be fixed now.
> 
> 
> Thanks,
> 
> Benson
> 
> 

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]