[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] Review Request: Set MSN message state to error
From:       "Matt Rogers" <mattr () kde ! org>
Date:       2009-03-20 12:53:39
Message-ID: 20090320125339.24864.96715 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/351/#review530
-----------------------------------------------------------

Ship it!


looks fine to me. please commit.

- Matt


On 2009-03-17 20:15:34, Benson Tsai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/351/
> -----------------------------------------------------------
> 
> (Updated 2009-03-17 20:15:34)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> If the message ack is not received within 60 seconds, the message state should be \
> set to error because the message probably didn't make it through. Further more, if \
> the client fails to acquire a switchboard connection with the contact, then all the \
> messages sent should also be set to error. As it stands, the client will try to \
> acquire a switchboard connection 3 times before giving up.  
> I also made two tiny changes. I made the destructor virtual because it is a good \
> practice and I made a function that used modulo in a rather funky way just simply \
> just a bitwise and. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmchatsession.h 940554 
> /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmchatsession.cpp 940554 
> 
> Diff: http://reviewboard.kde.org/r/351/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benson
> 
> 

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]