[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    [kopete-devel] Bug in winpopup protocol for kopete
From:       Pali Rohár <pali.rohar () gmail ! com>
Date:       2008-10-15 13:33:18
Message-ID: 48F5F11E.8020703 () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Hello,
I fix sending messages in winpopup. Messages wasnt delivered and const
QString &Body has a lot of white spaces at the end in void
WinPopupLib::sendMessage(const QString &Body, const QString &Destination)

And on my *buntu sh doesnt support echo -e (parm e). It support only
bash. I changed header in winpopup scripts to use bash (instead sh)

-- 
Pali Rohár
pali.rohar@gmail.com

["winpopup.patch" (text/x-patch)]

Index: winpopup-send.sh
===================================================================
--- winpopup-send.sh	(revision 871741)
+++ winpopup-send.sh	(working copy)
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 PATH=/bin:/usr/bin/:/usr/local/bin
 
 # Check input
Index: winpopup-install.sh
===================================================================
--- winpopup-install.sh	(revision 871741)
+++ winpopup-install.sh	(working copy)
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 
 PATH=/bin:/usr/bin
 
Index: libwinpopup/libwinpopup.cpp
===================================================================
--- libwinpopup/libwinpopup.cpp	(revision 871741)
+++ libwinpopup/libwinpopup.cpp	(working copy)
@@ -323,8 +323,8 @@
 	QProcess *sender = new QProcess(this);
 	QStringList args;
 	args << "-M" << Destination << "-N" << "-";
-	sender->start(smbClientBin);
-	sender->write(Body.toLocal8Bit());
+	sender->start(smbClientBin, args);
+	sender->write(Body.trimmed().toLocal8Bit());
 	sender->closeWriteChannel();
 }
 

["signature.asc" (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]