[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [RFC PATCH] (4.1.1) kopetemessage.cpp:
From:       "Roman Jarosz" <roman.jarosz () gmail ! com>
Date:       2008-09-28 19:55:57
Message-ID: op.uh7izjs7rj95b0 () localhost
[Download RAW message or body]

On Sun, 28 Sep 2008 15:05:57 +0200, Matěj Laitl <strohel@gmail.com> wrote:

> Hello again,
> last today's patch adds one more regexp pass into escapedBody() - without
> that, superfluous <p style="..."> and </p> is returned around escaped  
> body,
> causing unneeded newlines in history dialog. It shouldn't add any side  
> effects
> in normal chat window.
>
> Note: I was unable to achieve this by just adding additional fields into
> original regexp, maybe because we need to match start of the document,  
> which
> changes. (also, it didn't work when placed before newline filtering)  
> Someone
> more knowledgeable than me may know slightly more correct solution.
>
> Regards,
> 	Matěj Laitl

We already tried that and it sometimes removes new lines and this function is
also used in protocols so we can't do that.

I've already created similar code which removes the P tags and replaces it with
BR tags. The function also changes some tags for AIM protocols but that should
be easy to remove. The code is in kopete/protocols/oscar/aimcontactbase.cpp
in function AIMContactBase::slotSendMsg.

Regards,
Roman
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic