[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] changeGlobalStatusMessage and
From:       adrian <iamcalvo () gmail ! com>
Date:       2007-04-24 13:21:01
Message-ID: 200704241521.02498.iamcalvo () gmail ! com
[Download RAW message or body]

On Tuesday 24 April 2007 06:53:58 Matt Rogers wrote:
> On Apr 23, 2007, at 8:03 PM, adrian wrote:
> > Hi kopete developers!
> >
> > I'm Adrián Medraño Calvo. This is my first contribution to the KDE
> > Project
> > I'm leaving here for review, so critics are almost required :).
> >
> > What does this patch do?
> > - Creates Kopete::UI::KSaveLineEdit class, a QLineEdit with the
> > ability to
> > save it's contents with a mouse click and show changes-saved or
> > changes-not-saved state.
> > - Creates Kopete::KLineEditAction, an action that requires inline
> > text input
> > (not a dialog).
> > - Makes editGlobalIdentityToolbar and setStatusMessage use
> > KLineEditAction.
> > - Removes some krazy complains (kopetewindow.cpp duplicated includes,
> > contactlist->contactList).
> > - Fixes some broken funcionality:
> > 	- selecting "No message" in globalStatusMessageMenu didn't work
> > because
> > 		Kopete::Away::setGlobalAwayMessage didn't allow empty qstrings
> > (this is the
> > 		change I'm less confident about).
> > 	- selecting any previous globalStatusMessage didn't work because
> > all had same
> > 		index assigned: 0, as "No message".
> >
> > Questions:
> >
> > keditlineaction:
> > - I measured by eye(?¿!) Qlabel margins for imitating menu items
> > and hardcoded
> > them(wahwhawha!), is there any global value that could be used
> > instead?
> > - is the clear-focus-when-saved behaviour ok?
> >
> > kopetewindow.cpp&kopeteeditglobalidentitfywidget.cpp:
> > - Are the icon("edit") and text("Edit") wanted and accurate for
> > actionChangeGlobalNickname?
> > - Are the icon("document-new") and the text("New") wanted and
> > accurate for
> > actionChangeGlobalStatusMessage?
> >
> > Sure i forget lots of questions :).
> > Bye!
> > <lineedit.patch>
>
> Hi Adrián,
>
> Could you explain a little bit about what functionality your patch
> adds? Right now, the only thing I see are two new classes, some
> updates to use those classes, some krazy fixes, and a few bug fixes.
> I'm not personally able to put together a good picture in my head of
> what this is for. I'd appreciate it if you could explain it.
>
> Thanks
> --
> Matt

Of course,

Functionallity changed:
-	Before when the global nickname was edited it changed its color to red 
indicating your changes weren't saved. When you pressed return it's color 
returned to black indicating your changes were saved. This feedback is 
explict but hard to understand (why is it red?ah it's not saved, how do i save 
it?) the first time. Also I was missing it when I edited my global status 
message.
	Now both input boxes behave the same way: when you edit the text the 
save icon shows an enabled state(colorfull). When you press return or click 
on the save icon it shows disabled state and the lineedit loses keyboard 
focus.

-	Edit Global Identity toolbar is now thiner as it's margins were reduced.

-	Now selecting "No message" as global status message works.

-	Now selecting a recent global status message works.

Functionality added:
-	Now Edit Global Status Message lineedit shows your current global status 
message (http://bugs.kde.org/show_bug.cgi?id=124161 and 
http://bugs.kde.org/show_bug.cgi?id=130924).

-	Now users can update the global nickname or status message pressing on a 
button in the lineedit (see screenshots).

Side effects:
-	Now developers can easily asociate an icon or a descriptive text to a 
lineedit and insert them in toolbars and menus gracefully adapting its style 
(disclaimer: as I said in previous mail this is not true as I haven't yet 
found any global values for the margins. This can result bad with other 
styles than the default).

-	Code is more encapsulated making it easier to mantain.

Well, I think that's all. Please don't doubt asking more if i wasn't clear 
enough.

Kind regards,
Adrian Medraño.

["globalStatusMessageMenu.png" (image/png)]
["editGlobalIdentityWidget.png" (image/png)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]