[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    [kopete-devel] [Bug 118128] Wrong MSN contact when a window opens
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2005-12-11 19:23:11
Message-ID: 20051211192311.19792.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=118128         
ogoffart kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From ogoffart kde org  2005-12-11 20:23 -------
SVN commit 487744 by ogoffart:

Use a stack instead of a queue to open chatwindow.  and clear regulary this stack.


That mean the priority is given to the last contact you ask to chat to.

This fix Bug 118128: Wrong MSN contact when a window opens
BUG: 118128

Something which trigger this bug is also the fact that it need to download lots of \
picture when kopete start. disabling the automatic download of picture may help. \
(this bug, with the combinaison of Bug 117089 may be really annoying.)





 M  +4 -2      msnaccount.cpp  


--- branches/KDE/3.5/kdenetwork/kopete/protocols/msn/msnaccount.cpp #487743:487744
 @ -169,6 +169,7  @
 		m_notifySocket=0L;
 	}
 
+	m_msgHandle.clear();
 
 	myself()->setOnlineStatus( MSNProtocol::protocol()->CNT );
 
 @ -397,7 +398,7  @
 			i18n( "Connection Lost - MSN Plugin" ), KMessageBox::Notify );
 	}
 #endif
-
+	m_msgHandle.clear();
 	// kdDebug( 14140 ) << "MSNAccount::slotNotifySocketClosed - done" << endl;
 }
 
 @ -1167,7 +1168,7  @
 	{
 		if ( !c->manager(Kopete::Contact::CannotCreate) || !static_cast<MSNChatSession *>( \
c->manager( Kopete::Contact::CanCreate ) )->service() )  {
-			m_msgHandle.append(handle);
+			m_msgHandle.prepend(handle);
 			m_notifySocket->createChatSession();
 		}
 	}
 @ -1270,6 +1271,7  @
 	kdDebug(14140) << k_funcinfo << msg << endl;
 	// Display the error
 	KMessageBox::queuedMessageBox( Kopete::UI::Global::mainWidget(), msgBoxType, msg, \
caption ); +
 }
 
 bool MSNAccount::createContact( const QString &contactId, Kopete::MetaContact \
*metaContact ) _______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]