[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] Decouple tabs from the ChatView class
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2005-06-05 21:21:50
Message-ID: 200506052321.56877.ogoffart () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Le Dimanche 5 Juin 2005 21:24, Matt Rogers a écrit  :
> Hi,

Hi, i finally took the time to reply today :-)

> The attached patch removes the most of implementation details of tabs from
> the ChatView class and moves them to the KopeteChatWindow class. This is so
> that I can (if I have to) write a new chatwindow using the ChatView class
> as a base for my chat window without having to worry about the underlying
> tab widget implementation.

Yes, this is a good idea.

> This is a preliminary patch. The handling of the tab state from
> KopeteChatWindow (I'm talking about the colors for the tabs based on
> whether a user is typing, we've received a message, etc.) is missing. I
> would like some advice on how to get this moved the best. I still think
> that the ChatView class has to track it's state and the current patch
> reflects that, but some suggestions on how to proceed from here is welcome.

I don't understand really the question.
But having a  enum ChatView::State() and stateChanged signal would IMO be the 
solution.

Also, while talking about that, You probably know that i added a "preview 
latex message"  action in the chatwindow.
Currently, the randering is done blocking, which is bad, but later, it will be 
assychronous.
I want however to have a  "Rendering latex..."  in the statusbar.
That would require the addition of  KopeteView::setStautsMessage(QString) / 
statusMessage  (or in KopeteChatSession ?)

And you will have to track that also.
the default message must stay "%1 people in chat" .  and the "XXX is typing" 
should probably override everything.



[Attachment #5 (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]