[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] [PATCH] Decouple tabs from the ChatView class
From:       "Duncan Mac-Vicar P." <duncan () kde ! org>
Date:       2005-06-05 20:23:28
Message-ID: 200506051623.28630.duncan () kde ! org
[Download RAW message or body]

On Sunday 05 June 2005 15:24, Matt Rogers wrote:
> Hi,
>
> The attached patch removes the most of implementation details of tabs from
> the ChatView class and moves them to the KopeteChatWindow class. This is so
> that I can (if I have to) write a new chatwindow using the ChatView class
> as a base for my chat window without having to worry about the underlying
> tab widget implementation.
>
> This is a preliminary patch. The handling of the tab state from
> KopeteChatWindow (I'm talking about the colors for the tabs based on
> whether a user is typing, we've received a message, etc.) is missing. I
> would like some advice on how to get this moved the best. I still think
> that the ChatView class has to track it's state and the current patch
> reflects that, but some suggestions on how to proceed from here is welcome.

is that handling in ChatView right now? (supposing chatview knows about tabs).
Can answer it right now. I will think of it. It is not trivial to think a 
clean solution. Richard, are you reading?, you always have interesting 
solutions with your patterns...

Duncan

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]