[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [kopete-devel] my first bugfix :)
From:       Chani <chani () aebc ! com>
Date:       2005-06-03 9:33:19
Message-ID: 200506030233.25630.chani () aebc ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On June 3, 2005 02:18, Olivier Goffart wrote:

> > > 2) Add a link so that a popup menu may be shown when someone write
> > > someone's nick.
> > >
> > > IMO, this function is broken because
> > > 1) nick emoticons now appears now in the chat window
> > > 2) i don't see the interest off adding nick links, specially because it
> > > is very slow in a IRC channel.
> >
> > in single chats, however, it can be useful.
>
> please explain why.

I'm too lazy to go hunt down the user in the contact list when I want to send 
a file or something, and I usually keep the menu hidden.
actually... now that I think about it, I rarely use it :) I'm just used to it 
being htere.


> > hmm. correct.diff still manages to break links, because by default the
> > names show up without emoticons in incoming messages.
>
> oh, then there is another problem.
> the parseEmoticon should be placed in KopeteMessage::toXML
> the problem is that style will render it badly.

this whole thing seems like it's becoime a bit of a mess...

>
> > it seems to me that if links are to be kept (imho they're a good thing)
> > then status messages have to behave the same as the names for incoming
> > messages. so either they all have emoticons, or they all don't. I really
> > hope they can all have emoticons. I like emoticons. they're pretty :) and
> > in names you generally don't have the problem of code being interpreted
> > as emoticons. :)
> >
> > so, I'll attach two patches: one that consistently works with emoticons,
> > and one that consistently works without them.
> >
> > actually... no. I can't do that.
> > I can't figure out how to make it work without emoticons, because that's
> > what started my bug-hunt in the first place. trying to remove them from
> > status messages has very weird and unpredictable consequences, so you get
> > about half the emoticons showing up at random, and that really bugs me.
>
> I don't understand,  what are status messages ?

sorry, I'm not quite sure what they're called.. messages like 'user has left 
chat' or 'user has changed their name'. especially in the ones where they 
change their name.. weird things happen...

>
> > so.. afaik, the only diffs that will produce nice, sane results are your
> > dream.diff (which I personally don't want) and my attached diff.
> > I've tested my diff and it *appears* to work exactly how I want it... but
> > I am tired so I don't fully trust that :)
>
> The attached patch look better, yes.
>
> but this way to parse emoticon in nick is very slow,  one should instead
> parse them at the source.  ie in Kopete::Message::toXML

yeah, it did seem kinda messed up to me. when I'm awake I'll look over the 
code again and see if I can find a better way of parsing emoticons...
I have a feeling that the kopete messages returned the to'from stuff as 
contacts, not as strings, so it couldn't be done there.. or something like 
that... heck, maybe the contact itself should return the name with emoticons? 
or does that break other things?
eh... too late at night to be thinking...

-- 
This insane ranting was brought to you by evyl bananas, and the number 3.
Blaa! 8-)
www.chani3.com

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel


[prev in list] [next in list] [prev in thread] [next in thread]