[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    [Kopete-devel] Re: kdenonbeta/kopete/libkopete
From:       Grzegorz Jaskiewicz <gj () pointblue ! com ! pl>
Date:       2003-07-06 19:21:36
[Download RAW message or body]

On Sun, 6 Jul 2003, Martijn Klingens wrote:

> On Sunday 06 July 2003 17:13, Grzegorz Jaskiewicz wrote:
> > CVS commit by gj:
> >
> > Adding virtual QString fullAccountName() const; method to kopeteAccount
> > class. This will, among probably other use - will be used as status icon
> > tooltip text. It _DOESN'T_ break the API. By default (if not implemented)
> > it returns accountId();
> >
> > (...)
> >
> > +QString KopeteAccount::fullAccountName() const
> > +{
> > +    return accountId();
> > +}
> 
> I still don't see why you want this.
> 
> Why not use the same thing everywhere? Why would an account need to provide 
> its own implementation?
> 
> Personally I'd rather see you revert this :(
Does it do any harm ? It is very good thing, imho. Account can provide 
this way string that - in human readable form - gives full information 
about protocol, account ID and nickname.

This adds no harm to anything, and is needed to display information fe. in 
tooltip. And can be used by plugin it self to generate header of anything 
that requires that information.

We can add callback for tooltip, that will ask application for string each 
time it want to be displayed. But do you want that ?

This does not break API.
I have no reason to revert this, i even think it is very good idea to 
implement this function in each plugin. Small and do something usefull.

This is one step further to make kopete userfriendly


--
GJ



_______________________________________________
Kopete-devel mailing list
Kopete-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]