[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [Kopete-devel] PATCH: MSN error codes handled (2)
From:       Bart Verwilst <verwilst () gentoo ! org>
Date:       2003-01-10 11:42:00
[Download RAW message or body]

Hehe, i just noticed that too.. stupid me :$
I gotten error 601 is not handled blabla, so i wanted to patch it, and grepped 
the msn dir for "500" (a common error code ;o) and this was the first file i 
get which held that number.. I was kinda surprised seeing only one error code 
mentioned though :o) I'm willing to redo the changes, the way you guys think 
it's best (i know, it's just trivial, but i started learning c++ yesterday 
only ;) and patching gets me to learn a lot :o) (Although it isn't very hard 
so it seems, because i've been programming in python for almost 2 years..)

Let me know! Thanks

On Friday 10 January 2003 10:01, Martijn Klingens wrote:
||  On Friday 10 January 2003 02:47, Jason Keirstead wrote:
||  > The patch looks clean (and usefull)
||
||  But it's not correct I think :)
||
||  >  I will commit it tonight if no one objects within the next hour :)
||
||  Hmm, I couldn't object since I was asleep :P
||
||  To explain the problem I see: MSNSocket is a base class for
|| MSNNotifySocket, MSNDispatchSocket and MSNSwitchBoardSocket. Whereas both
|| the notify socket and the dispatch socket have these error codes I wonder
|| if they also apply to the swtitchboard (and the file transfer socket too
|| btw).
||
||  If they do, then all error handling should go here to centralize it. If
|| they don't, this patch should have been applied to MSNAuthSocket instead
|| to only cover the notify and dispatch sockets.
||
||  Would it hurt to centralize this here? Any ideas?

-- 
Bart Verwilst
Gentoo Linux Developer, Desktop Team
Gent, Belgium
_______________________________________________
Kopete-devel mailing list
Kopete-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]