[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kopete-devel
Subject:    Re: [Kopete-devel] Re: kdenonbeta/kopete/protocols/icq_new
From:       Nick Betcher <nbetcher () kde ! org>
Date:       2002-11-02 4:02:47
[Download RAW message or body]

On Friday 01 November 2002 07:09 pm, Andy Goossens wrote:
> On Thursday 31 October 2002 15:21, Nick Betcher wrote:
> > CVS commit by nbetcher:
> >
> >
> > This fixes the compilation errors here. Kudos goes to Andy Goossens and
> > Dominique Devriese (for trying). This is slightly different from Andy's
> > patch because it accounts for utf8 messages, nicknames, and groups (I
> > hope the ICQ server supports utf8 nicks and groups, although it seems it
> > does).
>
> Thanks Nick (for trying) ;-)
>
> ICQ messages now end up with weird characters due to the wrong encoding.
> e.g. send "àbûüçèé" and you will get "à bûüçèé"
> Receiving is OK

That's probably due to your encoding. It makes no sense that latin1() would 
result in functional messages. UTF8 preserves the proper encoding for 
extended characters (including double wide characters). Latin1 only supports, 
you guessed it, latin based characters. My patch is correct, but maybe we 
need a way to select the encoding ASAP?

>
> Looks like my patch was the best one after all :-p
> Sorry Nick, Zack...
>
>
>
> Background information:
>
> http://webcvs.kde.org/cgi-bin/cvsweb.cgi/qt-copy/src/tools/qstring.h
> contains <code>
> #ifndef QT NO CAST ASCII
>     // like all ifdef'd code this is undocumented
>     operator char() const { return latin1(); }
> #endif
> </code>
>
> This was causing trouble when QT NO ASCII CAST was declared. As you can
> see, it uses the latin1() method to get the job done. My patch explicitly
> added the ".latin1()" part, so that it would compile when QT NO ASCII CAST
> was declared.
>
> I wasn't saying my patch was *perfect*, but at least it didn't change any
> logic in the icq plugin. And I didn't introduce new bugs ;-)

_______________________________________________
Kopete-devel mailing list
Kopete-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/kopete-devel
[prev in list] [next in list] [prev in thread] [next in thread]