[prev in list] [next in list] [prev in thread] [next in thread]
List: konversation-devel
Subject: Re: Review Request 110002: this fixes the nick auto-completion for (a<tab> types
From: mayank jha <mjnovice () gmail ! com>
Date: 2017-01-20 23:22:49
Message-ID: 20170120232249.31352.25450 () mimi ! kde ! org
[Download RAW message or body]
--===============8338693887009566037==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110002/
-----------------------------------------------------------
(Updated Jan. 20, 2017, 11:22 p.m.)
Status
------
This change has been marked as submitted.
Review request for Konversation.
Bugs: 235562
https://bugs.kde.org/show_bug.cgi?id=235562
Repository: konversation
Description
-------
"(a<tab>" won't complete any nicks starting with "a", for example. "(" shouldn't \
factor into the prefix, however, since it's not allowed within nicks.
Diffs
-----
src/irc/channel.cpp f055213
Diff: https://git.reviewboard.kde.org/r/110002/diff/
Testing
-------
runs fine!
Thanks,
mayank jha
--===============8338693887009566037==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110002/">https://git.reviewboard.kde.org/r/110002/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konversation.</div>
<div>By mayank jha.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2017, 11:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=235562">235562</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konversation
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">"(a<tab>" won't complete any nicks starting with \
"a", for example. "(" shouldn't factor into the prefix, \
however, since it's not allowed within nicks.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">runs fine!</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/irc/channel.cpp <span style="color: grey">(f055213)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110002/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8338693887009566037==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic