[prev in list] [next in list] [prev in thread] [next in thread]
List: konversation-devel
Subject: Re: Review Request 110002: this fixes the nick auto-completion for (a<tab> types
From: Peter Simonsson <peter.simonsson () gmail ! com>
Date: 2016-09-14 17:09:37
Message-ID: 20160914170937.18200.14561 () mimi ! kde ! org
[Download RAW message or body]
--===============0517856538099311472==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Sept. 7, 2016, 2:39 p.m., Peter Simonsson wrote:
> > Ship It!
Improved version applied to master
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110002/#review98977
-----------------------------------------------------------
On April 18, 2013, 8:57 p.m., mayank jha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110002/
> -----------------------------------------------------------
>
> (Updated April 18, 2013, 8:57 p.m.)
>
>
> Review request for Konversation.
>
>
> Bugs: 235562
> https://bugs.kde.org/show_bug.cgi?id=235562
>
>
> Repository: konversation
>
>
> Description
> -------
>
> "(a<tab>" won't complete any nicks starting with "a", for example. "(" shouldn't \
> factor into the prefix, however, since it's not allowed within nicks.
>
> Diffs
> -----
>
> src/irc/channel.cpp f055213
>
> Diff: https://git.reviewboard.kde.org/r/110002/diff/
>
>
> Testing
> -------
>
> runs fine!
>
>
> Thanks,
>
> mayank jha
>
>
--===============0517856538099311472==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110002/">https://git.reviewboard.kde.org/r/110002/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 7th, 2016, 2:39 p.m. UTC, <b>Peter \
Simonsson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Improved version applied to master</p></pre> <br />
<p>- Peter</p>
<br />
<p>On April 18th, 2013, 8:57 p.m. UTC, mayank jha wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konversation.</div>
<div>By mayank jha.</div>
<p style="color: grey;"><i>Updated April 18, 2013, 8:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=235562">235562</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konversation
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">"(a<tab>" won't complete any nicks starting with \
"a", for example. "(" shouldn't factor into the prefix, \
however, since it's not allowed within nicks.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">runs fine!</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/irc/channel.cpp <span style="color: grey">(f055213)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110002/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0517856538099311472==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic