[prev in list] [next in list] [prev in thread] [next in thread]
List: konversation-devel
Subject: Re: Review Request 121329: Add margins to "Edit Network" dialog.
From: Peter Simonsson <peter.simonsson () gmail ! com>
Date: 2016-09-17 17:38:55
Message-ID: 20160917173855.8978.61069 () mimi ! kde ! org
[Download RAW message or body]
--===============1592221557663571392==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121329/#review99241
-----------------------------------------------------------
This has been fixed in master at least
- Peter Simonsson
On Dec. 2, 2014, 5:07 p.m., Arnold Dumas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121329/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2014, 5:07 p.m.)
>
>
> Review request for Konversation and Eike Hein.
>
>
> Repository: konversation
>
>
> Description
> -------
>
> When setting up konversation as a new user, the "Edit Network" dialog look dumb as \
> there is no margins. All the widgets are collapsed to the dialog borders. This \
> might not be the best way to do it, feedback is more than welcomed.
>
> Diffs
> -----
>
> src/irc/servergroupdialog.cpp 61b8bd9
>
> Diff: https://git.reviewboard.kde.org/r/121329/diff/
>
>
> Testing
> -------
>
> The updated dialog looks much better.
>
>
> File Attachments
> ----------------
>
> Old appearance
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/02/768918de-bfcf-48ab-b437-e0c73c0037ac__konversation_dialog_old.png
> New appearance
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/02/7ee7a7ed-dcd5-4653-a937-252dd71cdc6c__konversation_dialog_new.png
>
>
> Thanks,
>
> Arnold Dumas
>
>
--===============1592221557663571392==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121329/">https://git.reviewboard.kde.org/r/121329/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
has been fixed in master at least</p></pre> <br />
<p>- Peter Simonsson</p>
<br />
<p>On December 2nd, 2014, 5:07 p.m. UTC, Arnold Dumas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konversation and Eike Hein.</div>
<div>By Arnold Dumas.</div>
<p style="color: grey;"><i>Updated Dec. 2, 2014, 5:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konversation
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When setting up konversation as a new user, the "Edit \
Network" dialog look dumb as there is no margins. All the widgets are collapsed to \
the dialog borders. This might not be the best way to do it, feedback is more than \
welcomed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The updated dialog looks much better.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/irc/servergroupdialog.cpp <span style="color: grey">(61b8bd9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121329/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/12/02/768918de-bfcf-48ab-b437-e0c73c0037ac__konversation_dialog_old.png">Old \
appearance</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/12/02/7ee7a7ed-dcd5-4653-a937-252dd71cdc6c__konversation_dialog_new.png">New \
appearance</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1592221557663571392==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic