From konversation-devel Sat Sep 17 17:38:55 2016 From: Peter Simonsson Date: Sat, 17 Sep 2016 17:38:55 +0000 To: konversation-devel Subject: Re: Review Request 121329: Add margins to "Edit Network" dialog. Message-Id: <20160917173855.8978.61069 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=konversation-devel&m=147413394107104 --===============1592221557663571392== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121329/#review99241 ----------------------------------------------------------- This has been fixed in master at least - Peter Simonsson On Dec. 2, 2014, 5:07 p.m., Arnold Dumas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121329/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2014, 5:07 p.m.) > > > Review request for Konversation and Eike Hein. > > > Repository: konversation > > > Description > ------- > > When setting up konversation as a new user, the "Edit Network" dialog look dumb as there is no margins. All the widgets are collapsed to the dialog borders. This might not be the best way to do it, feedback is more than welcomed. > > > Diffs > ----- > > src/irc/servergroupdialog.cpp 61b8bd9 > > Diff: https://git.reviewboard.kde.org/r/121329/diff/ > > > Testing > ------- > > The updated dialog looks much better. > > > File Attachments > ---------------- > > Old appearance > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/02/768918de-bfcf-48ab-b437-e0c73c0037ac__konversation_dialog_old.png > New appearance > https://git.reviewboard.kde.org/media/uploaded/files/2014/12/02/7ee7a7ed-dcd5-4653-a937-252dd71cdc6c__konversation_dialog_new.png > > > Thanks, > > Arnold Dumas > > --===============1592221557663571392== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121329/

This has been fixed in master at least

- Peter Simonsson

On December 2nd, 2014, 5:07 p.m. UTC, Arnold Dumas wrote:

Review request for Konversation and Eike Hein.

By Arnold Dumas.

Updated Dec. 2, 2014, 5:07 p.m.

Repository: konversation

Description

When setting up konversation as a new user, the "Edit Network" dialog look dumb as there is no margins. All the widgets are collapsed to the dialog borders. This might not be the best way to do it, feedback is more than welcomed.

Testing

The updated dialog looks much better.

Diffs

src/irc/servergroupdialog.cpp (61b8bd9)

View Diff

File Attachments

Old appearance

New appearance

--===============1592221557663571392==--